Date: Sun, 23 Jul 2017 19:21:20 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 220950] Mk/Scripts/check-stagedir.sh false negatives (with %%OPTIONS%%) Message-ID: <bug-220950-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220950 Bug ID: 220950 Summary: Mk/Scripts/check-stagedir.sh false negatives (with %%OPTIONS%%) Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Ports Framework Assignee: portmgr@FreeBSD.org Reporter: gerald@FreeBSD.org CC: freebsd-ports-bugs@FreeBSD.org It appears that Mk/Scripts/check-stagedir.sh completely misses files that appear - in the staging directory, and - are listed in pkg-plist with an %%OPTION%% prefix when OPTION is off. Those files should be included in packages (or when the port is installed),= but are not. And check-stagedir.sh should diagnose that those files are in stagedir, but= not included in pkg-plist. This is quite a problem! How to reproduce: 1. chdir $PORTSDIR/emulators/wine-devel 2. svn up -r 445571 (the version before I'll fix pkg-plist in a minute) 3. Run the following script (after adjusting STAGEDIR and PREFIX) #!/bin/sh STAGEDIR=3D$WRKDIRPREFIX/wine-devel-work/stage PREFIX=3D$WRKDIRPREFIX/wine-devel-prefix grep %%STAGING%% pkg-plist | while read f; do f=3D`echo $f | sed -e 's/%%STAGING%%//'` if [ -f "$STAGEDIR/$PREFIX/$f" ]; then printf "%s no longer contigent on %%STAGING%%?\n" "$f" fi done --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-220950-13>