From owner-freebsd-hackers@FreeBSD.ORG Fri Nov 19 01:57:14 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 82D97106564A; Fri, 19 Nov 2010 01:57:14 +0000 (UTC) (envelope-from swell.k@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id E2A378FC17; Fri, 19 Nov 2010 01:57:13 +0000 (UTC) Received: by wwd20 with SMTP id 20so3971103wwd.31 for ; Thu, 18 Nov 2010 17:57:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=3Fzvx9NNM7MosTNqP6Tr1YNsxdk8rog3Uco+6wO4PwI=; b=kMGd0BJflif19XDb1n5gIl9TlBcBeA0xBmyqzeca2K1cffzvDyhWIY7qtPkRLoctH2 +LsU2p62MjezAIOrJNdjCW4VZozAEYsWzKsjy7wYyoh6YBf249ggmxCS0DZG047oR7rl KFu28bfLTVu2GESGgG+NugzaiXhnO7ZAqzqXc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=e4Ic5AVjPiI+h96iJHT4yYmZIxfat6qI705pEeATXHpVb4mvnGnphcB+gKCJ6W8MAV 83W8OQVSoix/8zFqFlke5zkTmKCDgLjrmsKY6KaAtG2y2N17Re/hcmUPE1ChnpGQardM 8rB45LKX/G5WM0LiDzP6Ym+ADR1mD/lNpUWAw= Received: by 10.227.136.72 with SMTP id q8mr1552998wbt.52.1290131832643; Thu, 18 Nov 2010 17:57:12 -0800 (PST) Received: from localhost (khaki.feralhosting.com [91.121.141.21]) by mx.google.com with ESMTPS id i19sm721251wbe.11.2010.11.18.17.57.08 (version=SSLv3 cipher=RC4-MD5); Thu, 18 Nov 2010 17:57:11 -0800 (PST) From: Anonymous To: Alexander Best References: <20101118185837.GA44549@freebsd.org> <86y68q3yaz.fsf@gmail.com> Date: Fri, 19 Nov 2010 04:57:02 +0300 In-Reply-To: <86y68q3yaz.fsf@gmail.com> (Anonymous's message of "Fri, 19 Nov 2010 04:19:16 +0300") Message-ID: <8662vu3wk1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain Cc: freebsd-hackers@freebsd.org Subject: Re: [patch] reminding developers to check for duplicates in ObsoleteFiles.inc and tools/build/mk/OptionalObsoleteFiles.inc X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Nov 2010 01:57:14 -0000 Anonymous writes: > Alexander Best writes: > >> diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc >> index e358ed9..106c10e 100644 >> --- a/ObsoleteFiles.inc >> +++ b/ObsoleteFiles.inc >> @@ -13,6 +13,12 @@ >> # >> # The file is partitioned: OLD_FILES first, then OLD_LIBS and OLD_DIRS last. >> # >> +# Before you commit changes to this file please check, if any entries in >> +# tools/build/mk/OptionalObsoleteFiles.inc can be removed. The following >> +# command was proposed by Dmitry Morozovsky: >> +# ( grep '+=' /usr/src/ObsoleteFiles.inc | sort -u ; \ >> +# grep '+=' /usr/src/tools/build/mk/OptionalObsoleteFiles.inc | sort -u) | \ >> +# sort | uniq -d > > An easier way to check duplicates that understands `.if ${TARGET_ARCH}...' > > $ make -V OLD_FILES -V OLD_LIBS -V OLD_DIRS \ > -f Makefile.inc1 check-old \ > | sed 'y/ /\n/' | sort | uniq -d Nevermind. It's more important to check OptionalObsoleteFiles.inc when files are re-introduced and thus removed from ObsoleteFiles.inc.