From owner-cvs-all@FreeBSD.ORG Tue Jan 11 10:39:27 2011 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A7F181065694; Tue, 11 Jan 2011 10:39:27 +0000 (UTC) (envelope-from gljennjohn@googlemail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 642588FC20; Tue, 11 Jan 2011 10:39:25 +0000 (UTC) Received: by fxm16 with SMTP id 16so19803196fxm.13 for ; Tue, 11 Jan 2011 02:39:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:in-reply-to:references:reply-to:x-mailer:mime-version :content-type:content-transfer-encoding; bh=CvsmLur1/errglR42KmfyHwfrcOld94XoO1f810FXgE=; b=RKX+tH0sm8itINwJsq5Eu8X1zu8WgBBWd+0E3qQfUkOZ+kGQ5U7wVcfhpbkS+4c4VL rH2LQ7aB9u0v+9pCz5kQauCf0nL8hl+baECogyjr7x7xG4D76ZZsoFCcPByXPHZ5ywDJ ge6MTiJLe2BsrxkMNA0jD9OM7aroT8Y/vj7hk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :x-mailer:mime-version:content-type:content-transfer-encoding; b=p31YXwwRwOJncsh8Ox+t5GHeEFvQnE6OUs60lqgg8tCtppzK5E8GZ4RXeUWoJ93uaO l3SYTnXTI+YjG8so1bqxxNLyTvx/V1UNgqu0AUoSCITIb88mcOv/cWQAOEfDH9+fEQo3 ff4eBuccVU5dBsnglOthR81OM95MDohtymfiw= Received: by 10.223.103.12 with SMTP id i12mr5909048fao.43.1294740803378; Tue, 11 Jan 2011 02:13:23 -0800 (PST) Received: from ernst.jennejohn.org (p578E3168.dip.t-dialin.net [87.142.49.104]) by mx.google.com with ESMTPS id n15sm7301936fam.36.2011.01.11.02.13.20 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 11 Jan 2011 02:13:21 -0800 (PST) Date: Tue, 11 Jan 2011 11:13:16 +0100 From: Gary Jennejohn To: Alexey Dokuchaev Message-ID: <20110111111316.660727e8@ernst.jennejohn.org> In-Reply-To: <20110111055845.GA19115@FreeBSD.org> References: <201101100135.p0A1ZLEL028834@repoman.freebsd.org> <20110110014602.GB92966@FreeBSD.org> <20110110041847.GB5992@magic.hamla.org> <20110110065210.GA24349@FreeBSD.org> <95244161@h30.sp.ipt.ru> <20110111055845.GA19115@FreeBSD.org> X-Mailer: Claws Mail 3.7.8 (GTK+ 2.18.7; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Sahil Tandon , Wen Heping , cvs-all@freebsd.org, ports-committers@freebsd.org, Boris Samorodov , cvs-ports@freebsd.org Subject: Re: cvs commit: ports/sysutils/tmux Makefile ports/sysutils/tmux/files extra-patch-configure X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: gljennjohn@googlemail.com List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jan 2011 10:39:27 -0000 On Tue, 11 Jan 2011 05:58:45 +0000 Alexey Dokuchaev wrote: > On Tue, Jan 11, 2011 at 08:03:40AM +0800, wen heping wrote: > > 2011/1/11 Boris Samorodov : > > > On Mon, 10 Jan 2011 06:52:10 +0000 Alexey Dokuchaev wrote: > > >> On Sun, Jan 09, 2011 at 11:18:48PM -0500, Sahil Tandon wrote: > > >> > > > >> > http://lists.freebsd.org/pipermail/freebsd-ports/2010-March/060003.html > > > > > >> Kudos to gj@ for his investigation; I hope clueful guys will eventually > > >> solve the problem properly. But commit message could be improved > > >> considerably if it included that text from ports@ at least partially. > > >> This would save the list from my stupid questions, and interested folks > > >> might decide to help Gary and Andriy fixing this issue. > > > > > > Well, after that commit the port is broken: freezes in minutes: > > > [...] > > > > I agree commit message should include more message of the run error to > > help others resolve the problem. But: some days ago, garga@ send me > > a mail with a scipts written by him to confirm me there would be run error > > if tmux build with kqueue on some special platform. I think it is not easy > > to include this message in serveral lines in commit log. > > I haven't seen the message sent to you by garga@, but for example for > the above analysis given by gj@ I think approprite shorter message could > be: > > Disable kqueue support for now; apparently, devel/libevent thinks our > kqueue(2) implementation is broken: it assumes that kevent() will > always return 1 on success. According to kqueue(2) kevent will return > up to nevents on success. > > Analyzed by: gj@ > > When in doubt, there is community to ask. :-) > I actually changed libevent to check for <= 0 when calling kevent() and then installed tmux. My tmux *does* use libevent. Unfortunately, my tmux also shows the hang problem reported by Boris Samorodov, and I'm running 9-current. However, I only see the hang on the console after closing the last-to-one pane in tmux, i.e. only one pane remains active. When multiple panes are active I observe no problems. I also haven't noticed any problem at all when I run tmux in mrxvt. There I can create and close panes without any hangs. But I only did limited testing with mrxvt. -- Gary Jennejohn (gj@)