From nobody Tue Mar 3 19:25:11 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fQQk353Gzz6TWhH; Tue, 03 Mar 2026 19:25:15 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fQQk34DvDz3Z73; Tue, 03 Mar 2026 19:25:15 +0000 (UTC) (envelope-from bz@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772565915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mBnaKboyQ7Z6F3LqrJI3uQdaPpV6hYhoCHXKJ174LRI=; b=y0Y7oVYErVTw7Ib/iL1IyBFTAAUaZbjzM6OX+SJ/7C3W7J7ON0M1w4gFTtxCuDHCAlyzoN MohneeKI6jLA299YS4tu94E4Z7DRBRqq06M0jkxov2rVeTvVEBa8qLb6dUN50nagk16XdX lRzTQqXBBIoklXcxOKwyy3Yk/ctFDCv2PCbFmQBNEuwQonSy92HaeqM+kLjqHFTDFSoDii Va9mvYRmgYaYpUcMK1mWQm16etbDMESw8aXv+NCsS3keoy3uBfilLKfRNfISL8YfhPVwsX TCytiAVxjHeiq7QRT0QX1gkM2dxyWouPQdiQbncsTwAd03cqC+NBupfUDUAByA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1772565915; a=rsa-sha256; cv=none; b=Vpc8LdUSfdU72snzYvVbX96IAjYdqhgDKZmn6D7AtdBo2PyEvPaa8NfMEGHkIuPZmwZ9Jh qYg0/ACTZoADG4OX3aO1wperpmCUJVki9D4bTi5OW22HukDAUOwe0RbI6d8JAsMxnXsFww A9KV9Hf1I+rwEEoE16Opt2G6P2jCt0woUmwZO25nALLHoQA8YtmzL5AZTxW6zdo97h+x37 DbHCo2ountp5CSb8oQW5HGnrsTEdL1ZrVNOCob8mkSsu4kizMvM1R9gCHUh2BJnkh8x9Vs lBR75RkqdTnGV8cLJc9slV7qJ6Jirb9UyNOrXGiybhI9Z+oT45vdbKynqRdp8w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772565915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mBnaKboyQ7Z6F3LqrJI3uQdaPpV6hYhoCHXKJ174LRI=; b=IFgCuNFzsTjUPtmwROyVPjBRGHBkQyWkeOe35OmyPl9GseVkVeHcAdxMVabIRkCq/mt7RP i7FUgWVKoCNQ+C6PdmR9SElQ13Ev/Xs7LGF2QkcFGVlV5M62+vaOPDtC2KpKYLwq5c+G0a SW+mo1BQpDKyu1thPN/E4PQhwtVCjJUwe6HVaTC2VHHcMh4P05lZu22fmHbcujyr/e5Jc6 wZXCExoXM+GDqArao1bDgXPUnNF9j3G7uneWvhmHp9WEo1ETSKxzhe98Y99+nrUJIo63ui a2RJGZIiKB+yESxZl/g5b0bYHEfvqxzGYSRHHdWkWK/Nftr420ujw9xyRhtPXQ== Received: from mx-01.divo.sbone.de (legacy1.sbone.de [80.151.10.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E7" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fQQk32G0pzkVm; Tue, 03 Mar 2026 19:25:15 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 712C5A64806; Tue, 03 Mar 2026 19:24:54 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 86DDC2D029E7; Tue, 3 Mar 2026 19:25:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id yZT96Hvrjz1a; Tue, 3 Mar 2026 19:25:12 +0000 (UTC) Received: from nv.t4-02.sbone.de (nv.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 0B92F2D029D8; Tue, 3 Mar 2026 19:25:12 +0000 (UTC) Date: Tue, 3 Mar 2026 19:25:11 +0000 (UTC) From: "Bjoern A. Zeeb" To: Warner Losh cc: Enji Cooper , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: c47cefba8312 - main - Only build USB-related modules if MK_USB != no In-Reply-To: Message-ID: <947orn62-43rq-383n-son8-90o6q2275os6@serrofq.bet> References: <69a668aa.3785e.4a16f236@gitrepo.freebsd.org> <1s9oq316-3q4o-9273-3qos-3n3o793ns725@mnoonqbm.arg> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="0-1526680494-1772565912=:11296" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-1526680494-1772565912=:11296 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Tue, 3 Mar 2026, Warner Losh wrote: > On Tue, Mar 3, 2026 at 11:29 AM Bjoern A. Zeeb wrote: > >> On Tue, 3 Mar 2026, Enji Cooper wrote: >> >>> The branch main has been updated by ngie: >>> >>> URL: >> https://cgit.FreeBSD.org/src/commit/?id=c47cefba831240a1b3de375f18134b93cf998f5c >>> >>> commit c47cefba831240a1b3de375f18134b93cf998f5c >>> Author: Enji Cooper >>> AuthorDate: 2026-03-03 04:49:54 +0000 >>> Commit: Enji Cooper >>> CommitDate: 2026-03-03 04:50:03 +0000 >>> >>> Only build USB-related modules if MK_USB != no >>> >>> This change moves the thunderbolt module and other USB modules under a >>> MK_USB != no conditional to ensure that users not desiring USB support >>> can easily build systems without USB-specific drivers using this knob. >>> >>> MFC after: 1 week >>> Reviewed By: imp >>> Differential Revision: https://reviews.freebsd.org/D55576 >>> --- >>> sys/conf/kern.opts.mk | 5 +++++ >>> sys/conf/kmod.mk | 8 ++++++-- >>> sys/modules/Makefile | 16 ++++++++++------ >>> 3 files changed, 21 insertions(+), 8 deletions(-) >> >> There is a hige load of further devices which depend on USB which are not >> part of the current set excluded; I assume they will now break with >> dependency >> issues if USB is no longer built but these modules are built. >> >> Is there any plan to also "hide" all the other modules? >> > > As I said in my review, I'm generally uneasy about this trend... I never got that far as the review diff I looked at was broken at that point. This may also be wrong: % ls -l tools/build/options/*USB* -rw-r--r-- 1 bz bz 49 Mar 21 2025 tools/build/options/WITHOUT_USB -rw-r--r-- 1 bz bz 40 Mar 21 2025 tools/build/options/WITHOUT_USB_GADGET_EXAMPLES -rw-r--r-- 1 bz bz 33 Mar 21 2025 tools/build/options/WITH_USB_GADGET_EXAMPLES % cat tools/build/options/WITHOUT_USB Do not build USB-related programs and libraries. Usually we used to have a FOO_SUPPORT which would then also not build kernel modules or not build FOO suport into (programs, libraries, and) kernel modules, e.g. INET, INET6, NETGRAPH. Though, unless INET and INET6 started to become loadable seems wrong these days and I'd use a check based on the kernel config (which I believe came years later as an option) and remove the entire MK_INET[6]_SUPPORT checks for the kernel. The NETGRAPH example is a bad one as it seems to be unimplemeted for the kernel side so NETGRAPH_SUPPORT description is misleading. USB tends to be more tricky as it is fully loadable but then then answer for people who don't want a system supporting USB would mean removing all the modules (which we cannot do based on the kernel config). The question then remains whether a src.conf based knob is the right thing and which one it should be. MK_USB seems wrong but more knobs do not make it better as we have too many of them these days if you ask me. The answer may simply be to rm the modules if a system does not want/need them. I kind-of see that as a rare special-case problem and if someone really needs to ship a system like that then they may have to go the extra length and maintain that bit? If we were really to support this in the build system then we should make sure that all USB modules are no longer build. Given I had my fingers in the USB modules list (though not the full one) recently "uneasy" is maybe not enough for the feeling in my stomach. /bz -- Bjoern A. Zeeb r15:7 --0-1526680494-1772565912=:11296--