From owner-svn-ports-all@FreeBSD.ORG Sat Oct 12 18:54:32 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id F075830F for ; Sat, 12 Oct 2013 18:54:31 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-lb0-f174.google.com (mail-lb0-f174.google.com [209.85.217.174]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 6DF5C2BE3 for ; Sat, 12 Oct 2013 18:54:31 +0000 (UTC) Received: by mail-lb0-f174.google.com with SMTP id w6so4462277lbh.19 for ; Sat, 12 Oct 2013 11:54:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=cAqv+CUqfYOCJeJHJLEzD3XNcm7SWYwQeu5Pz03d8Fs=; b=KkmjeZZ+OdymqE3gjRtNIHLV2a5bsEveupJm4sqUzGhcpI0RApZefGBUcB32Ep9UGD IQciPvvLB0P9p0qyjwFYBtCBmR8+G617lYLpBuhNjkbv3wQcYW9ZKLgeZWv2VfD77hJ+ u8+KdT63FoOP7iFPDSa8TSG6DKDyTUItOXkptpbpUdxu9BDhgs0zQ8SIFvz5QuCCRcb/ QNPTkNf8TJQRbJWn+IFa3Qu5lOrSnkd9XDXCbtLOcovNtCvOyMICvK40+sUzzrBox/78 j73YWv1FpW8uo8F7CWKgJ95UJ5uET453DAbiZ35+kdRrXaR0ZV0V9ZinS1jFvGK2JWr0 PiAw== X-Gm-Message-State: ALoCoQk4JuGpMh3H66B544pn8FjPOUw2fbz3VaDdiSRc5F36qicLJgAhDFLTWlltkhiCSTrD2nln X-Received: by 10.152.22.198 with SMTP id g6mr22013484laf.5.1381604062803; Sat, 12 Oct 2013 11:54:22 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.112.91.9 with HTTP; Sat, 12 Oct 2013 11:54:02 -0700 (PDT) In-Reply-To: <201310100009.r9A09Zah023159@svn.freebsd.org> References: <201310100009.r9A09Zah023159@svn.freebsd.org> From: Sunpoet Po-Chuan Hsieh Date: Sun, 13 Oct 2013 02:54:02 +0800 X-Google-Sender-Auth: zGNpKxB0jMYAA5X3nVyPeQM1EvE Message-ID: Subject: Re: svn commit: r329946 - in head/databases: postgresql84-client postgresql84-contrib postgresql84-docs postgresql84-server postgresql90-client postgresql90-contrib postgresql90-docs postgresql90-plper... To: Jason Helfman , pgsql@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Oct 2013 18:54:32 -0000 Hi Jason and pgsql@ team, May I suggest to remove DISTV as it's only used in PKGNAMESUFFIX and portlint complains [1]. I have prepared a patch [2] which contains 2 changes: 1) PKGNAMESUFFIX?=${DISTVERSION:R:S/.//}${COMPONENT} 2) Convert to new LIB_DEPENDS format for postgresql*-contrib ports I have also checked PKGNAME is unchanged after applying this patch. Please review it. Thanks. [1] FATAL: Makefile: extra item "DISTV" placed in the PORTNAME section. [2] http://people.freebsd.org/~sunpoet/postgresql-pkgname.patch Regards, sunpoet