From owner-freebsd-ports@FreeBSD.ORG  Mon May 21 22:39:14 2012
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 2052F106564A;
	Mon, 21 May 2012 22:39:14 +0000 (UTC)
	(envelope-from linimon@lonesome.com)
Received: from mail.soaustin.net (pancho.soaustin.net [76.74.250.40])
	by mx1.freebsd.org (Postfix) with ESMTP id E519D8FC14;
	Mon, 21 May 2012 22:39:13 +0000 (UTC)
Received: by mail.soaustin.net (Postfix, from userid 502)
	id AE76A56205; Mon, 21 May 2012 17:39:13 -0500 (CDT)
Date: Mon, 21 May 2012 17:39:13 -0500
From: Mark Linimon <linimon@lonesome.com>
To: Jason Helfman <jgh@FreeBSD.org>
Message-ID: <20120521223913.GB6247@lonesome.com>
References: <20120521220449.GD8317@dormouse.experts-exchange.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120521220449.GD8317@dormouse.experts-exchange.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-Mailman-Approved-At: Tue, 22 May 2012 01:00:52 +0000
Cc: nsand@sura.ru, jon@witchspace.com, kuriyama@FreeBSD.org, bobf@mrp3.com,
	emulation@FreeBSD.org, bkoenig@alpha-tierchen.de,
	hrs@FreeBSD.org, ports@freebsd.org, gelraen.ua@gmail.com,
	delphij@FreeBSD.org, ale@FreeBSD.org, rene@FreeBSD.org,
	admin@lissyara.su, vbox@FreeBSD.org, mirror176@cox.net,
	jkim@FreeBSD.org, mm@FreeBSD.org
Subject: Re: [RFC] Seeking Approval: include bsd.port.pre.mk so SRC_BASE is
 defined before referenced
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 May 2012 22:39:14 -0000

Thanks for doing this work.  A quick review looks to me to be TRT.

I would suggest some minor fixes but only for style: for me, it makes
it a bit clearer what's going on if the pre.mk include isn't among
the various WITH_* definitions, e.g. net/skystar2.  Or maybe just
having a blank line before the inclusion would help.

Also, for sysutils/fusefs-kmod, I would do the following:

 - move the MAKE_ENV= definition past the bsd.ports.pre.mk inclusion
 - throw the SRC_BASE?= line away.

mcl