From owner-cvs-all@FreeBSD.ORG Mon Jul 4 05:59:31 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A777816A420 for ; Mon, 4 Jul 2005 05:59:31 +0000 (GMT) (envelope-from silby@silby.com) Received: from relay01.pair.com (relay01.pair.com [209.68.5.15]) by mx1.FreeBSD.org (Postfix) with SMTP id C3CDB43D58 for ; Mon, 4 Jul 2005 05:59:30 +0000 (GMT) (envelope-from silby@silby.com) Received: (qmail 97985 invoked from network); 4 Jul 2005 05:59:29 -0000 Received: from unknown (HELO localhost) (unknown) by unknown with SMTP; 4 Jul 2005 05:59:29 -0000 X-pair-Authenticated: 209.68.2.70 Date: Mon, 4 Jul 2005 00:59:10 -0500 (CDT) From: Mike Silbersack To: Andrew Thompson In-Reply-To: <20050703235733.GA8138@heff.fud.org.nz> Message-ID: <20050704005749.D21939@odysseus.silby.com> References: <200507031824.j63IO3Bs009536@repoman.freebsd.org> <20050703184013.U21939@odysseus.silby.com> <20050703235733.GA8138@heff.fud.org.nz> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net bridge.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jul 2005 05:59:31 -0000 On Mon, 4 Jul 2005, Andrew Thompson wrote: >> What's the route that a packet takes before it gets to the bridge? If it >> goes through ether_input, it would make sense to put the alignment there >> when necessary. > > Both bridges tap their packets off near the end of ether_input(). Since > we only need to check alignment when using pfil(9) and each bridge has > its own knobs to control filtering, it seems best to leave it where it > is at the moment. Well, where it was at was the network drivers. Since we know that em is the (only?) violator, you're arguing for the backout of your patch when you say "leave it where it is." The other protocol stacks need aligned headers too, that's why I'm curious as to the bridge-specificness of this patch. Mike "Silby" Silbersack