From owner-freebsd-ports-bugs@FreeBSD.ORG  Fri Mar  7 13:10:01 2014
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 5A47F9F3
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Fri,  7 Mar 2014 13:10:01 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 36801D07
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Fri,  7 Mar 2014 13:10:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s27DA1pV069604
 for <freebsd-ports-bugs@freefall.freebsd.org>; Fri, 7 Mar 2014 13:10:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s27DA1p3069603;
 Fri, 7 Mar 2014 13:10:01 GMT (envelope-from gnats)
Resent-Date: Fri, 7 Mar 2014 13:10:01 GMT
Resent-Message-Id: <201403071310.s27DA1p3069603@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
        Trond Endrestøl <Trond.Endrestol@ximalas.info>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 376429E5
 for <freebsd-gnats-submit@FreeBSD.org>; Fri,  7 Mar 2014 13:09:06 +0000 (UTC)
Received: from cgiserv.freebsd.org (cgiserv.freebsd.org
 [IPv6:2001:1900:2254:206a::50:4])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 23BE0CFF
 for <freebsd-gnats-submit@FreeBSD.org>; Fri,  7 Mar 2014 13:09:06 +0000 (UTC)
Received: from cgiserv.freebsd.org ([127.0.1.6])
 by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s27D94Z1035726
 for <freebsd-gnats-submit@FreeBSD.org>; Fri, 7 Mar 2014 13:09:04 GMT
 (envelope-from nobody@cgiserv.freebsd.org)
Received: (from nobody@localhost)
 by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s27D944T035725;
 Fri, 7 Mar 2014 13:09:04 GMT (envelope-from nobody)
Message-Id: <201403071309.s27D944T035725@cgiserv.freebsd.org>
Date: Fri, 7 Mar 2014 13:09:04 GMT
From: Trond Endrestøl <Trond.Endrestol@ximalas.info>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Subject: ports/187349: print/xdvik/Makefile wrongfully assumes
 ${WRKSRC}/pkg-install is created with execute permission
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Mar 2014 13:10:01 -0000


>Number:         187349
>Category:       ports
>Synopsis:       print/xdvik/Makefile wrongfully assumes ${WRKSRC}/pkg-install is created with execute permission
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 07 13:10:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Trond Endrestøl
>Release:        FreeBSD 9.2-STABLE
>Organization:
Private
>Environment:
FreeBSD enterprise.ximalas.info 9.2-STABLE FreeBSD 9.2-STABLE #0 r262730: Tue Mar  4 14:46:38 CET 2014     root@enterprise.ximalas.info:/usr/obj/usr/src/sys/ENTERPRISE  amd64
>Description:
print/xdvik/Makefile wrongfully assumes ${WRKSRC}/pkg-install is created with execute permission.


>How-To-Repeat:
cd /usr/ports/print/xdvik && make install
>Fix:
I've created two patches. The first one turns on the execute permission, the second implicitly runs pkg-install through /bin/sh. (Whitespace is doomed to be lost below, type manually if you choose to use either patch.)

--- Makefile.orig       2014-03-06 20:03:59.625349000 +0100
+++ Makefile    2014-03-07 13:55:38.618351079 +0100
@@ -77,6 +77,7 @@
        ${MKDIR} ${DOCSDIR}
        cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${DOCSDIR}
 .endif
+       chmod a+x ${PKGINSTALL}
        @${PKGINSTALL} ${PKGNAME} POST-INSTALL

 .include <bsd.port.mk>


--- Makefile.orig       2014-03-06 20:03:59.625349000 +0100
+++ Makefile    2014-03-07 13:57:13.697351814 +0100
@@ -77,6 +77,6 @@
        ${MKDIR} ${DOCSDIR}
        cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${DOCSDIR}
 .endif
-       @${PKGINSTALL} ${PKGNAME} POST-INSTALL
+       @/bin/sh ${PKGINSTALL} ${PKGNAME} POST-INSTALL

 .include <bsd.port.mk>


>Release-Note:
>Audit-Trail:
>Unformatted: