From owner-freebsd-net@FreeBSD.ORG  Wed Dec 28 08:09:00 2011
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EC3AA106566C;
	Wed, 28 Dec 2011 08:09:00 +0000 (UTC)
	(envelope-from ermal.luci@gmail.com)
Received: from mail-tul01m020-f182.google.com (mail-tul01m020-f182.google.com
	[209.85.214.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 85D3D8FC0A;
	Wed, 28 Dec 2011 08:09:00 +0000 (UTC)
Received: by obbwd18 with SMTP id wd18so12182621obb.13
	for <multiple recipients>; Wed, 28 Dec 2011 00:09:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=Y56qS+cR1Irx3Gr68I7eMd8SPOB51rRp9ZKuHLPI3bs=;
	b=NEpfzeOZ1ja+RO7uu5d8JfYFzV+yqgFNYbFtkmQhDX+oEofbP8ruuHVQQkU9gFZYXQ
	DUNA/t/PwPmmdoxB0t4GQWuRyChD0VGPQOayBWHPFFbaZDYweEzmFHO4HPHOYo2xcAol
	JZawGqQZiTo3+DIHcf6D8hoXwzBdhvUykPoUE=
MIME-Version: 1.0
Received: by 10.50.161.135 with SMTP id xs7mr29607690igb.15.1325059740000;
	Wed, 28 Dec 2011 00:09:00 -0800 (PST)
Sender: ermal.luci@gmail.com
Received: by 10.231.183.76 with HTTP; Wed, 28 Dec 2011 00:08:59 -0800 (PST)
In-Reply-To: <20111227174655.GS8035@glebius.int.ru>
References: <201112221130.01823.jhb@freebsd.org>
	<20111227041728.GI8035@FreeBSD.org>
	<CAPBZQG1HvMJ_RnM1Fofidd=U7Ty7-2x7Csb9tnsQOSGtYENZRA@mail.gmail.com>
	<20111227174655.GS8035@glebius.int.ru>
Date: Wed, 28 Dec 2011 09:08:59 +0100
X-Google-Sender-Auth: aapGDDRAVctUW_XbzdJXt17XZP8
Message-ID: <CAPBZQG2DWhde0MyvJmJDpTUDg_OB2PDfTCOP4CL9m1kT_HEEBQ@mail.gmail.com>
From: =?ISO-8859-1?Q?Ermal_Lu=E7i?= <eri@freebsd.org>
To: Gleb Smirnoff <glebius@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: Robert Watson <rwatson@freebsd.org>, John Baldwin <jhb@freebsd.org>,
	net@freebsd.org
Subject: Re: Transitioning if_addr_lock to an rwlock
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Dec 2011 08:09:01 -0000

2011/12/27 Gleb Smirnoff <glebius@freebsd.org>:
> On Tue, Dec 27, 2011 at 11:29:02AM +0100, Ermal Lu?i wrote:
> E> 2011/12/27 Gleb Smirnoff <glebius@freebsd.org>:
> E> > On Thu, Dec 22, 2011 at 11:30:01AM -0500, John Baldwin wrote:
> E> > J> You can find the patch for 8.x at
> E> > J> http://www.freebsd.org/~jhb/patches/if_addr_rwlock.patch
> E> >
> E> > Just my two pennies: for head/ patching if ip_carp.c should
> E> > be straightforward:
> E> >
> E> > 1) Using W in carp_alloc_if() and carp_free_if().
> E> > 2) Using R everywhere else.
> E> >
> E>
> E> I would not say that is true!
> E>
> E> Look at this https://github.com/bsdperimeter/pfsense-tools/blob/master/patches/RELENG_8_1/carp_livelock_fixes.diff
> E> I already did this for carp on pfSense for 8.x and should be the same for HEAD.
> E> That has undergone testing and catching up where R vs W.
>
> Ermal,
>
> in head/ we already got new CARP implementation.
>
Gleb,

yeah but the 'new' there is just the interface provided to be
configured and not the protocol or code perse.
To me it is the same from locking perspective in 8.x and HEAD

For sure i will have to come to this when we move to 9 or HEAD in
pfSense but still think its not that simple as you said.

Regards,
Ermal