Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 29 Aug 2004 16:01:59 -0400
From:      <mezz7@cox.net>
To:        <pav@FreeBSD.org>, <freebsd-ports-bugs@FreeBSD.org>, Ulrich Spoerlein <q@uni.de>
Subject:   Re: ports/71111: [PATCH] games/wesnoth: update to 0.8.3
Message-ID:  <20040829200158.ZBNC17927.lakermmtao01.cox.net@smtp.east.cox.net>

next in thread | raw e-mail | index | archive | help
> From: Pav Lucistnik <pav@FreeBSD.org>
> Over to maintainer, but it looks very ugly anyway. We tried hard
> to avoid USE_GCC=3.3 here in the past, the new plist way looks
> very obfuscated too,

I will have to agree with pav here about looks very ugly. I don't approve this patch, but I shall take some good parts from this patch after ports tree freeze in my new patch. Sorry, it will not make it before ports tree freeze. However, the reason I don't approve this patch is remove pkg-plist, force gcc 3.3 and etc.

Why after ports freeze? Because, the 0.8 is stable version and the 0.8.x is development version that has a lot of bugs on FreeBSD such as 'overflow the argument list of the shell', can't compile and etc. Therefore, it is not worth to go in the ports tree yet.

> +USE_GETTEXT=   yes
> +USE_ICONV=     yes
> 
> superfluous USE_ICONV, USE_GETTEXT grant that, ...

Agree, I saw in the change log of 0.8.3 about using gettext now.

BTW: Please, don't take it personal, Ulrich. I am glad that you have done your best work to send patch and etc rather than bugging me to update like others. Therefore, thanks! :-)

Cheers,
Mezz



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040829200158.ZBNC17927.lakermmtao01.cox.net>