From owner-svn-ports-all@freebsd.org Fri Apr 13 13:43:47 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C7C3DF8A3EF for ; Fri, 13 Apr 2018 13:43:46 +0000 (UTC) (envelope-from jrm@ftfl.ca) Received: from mail-qt0-f171.google.com (mail-qt0-f171.google.com [209.85.216.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6CFD2832D9 for ; Fri, 13 Apr 2018 13:43:46 +0000 (UTC) (envelope-from jrm@ftfl.ca) Received: by mail-qt0-f171.google.com with SMTP id w23so8056934qtn.3 for ; Fri, 13 Apr 2018 06:43:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=PsvZFbCGj3P9aDf07aALJ/GkQNYLnG209ivkYbVkGnY=; b=ErIDZGv30scjyqmzc6iRsDJ6ymLweQ30Rzt0UTVLT4KnuyNjVy1fljXFGSaSuk+PRS nqm+i0gR9Xuxb4gV06iak8lmz/Q/yeQJbGg0Q6/G6o3TIFIPX+7QFlMkjPR+LkC8B3BX nxgv7cua8P0nadjLTXN0WUiIzRpPvUdq263CydgqkfVecEUQW2CcDp/Layx7WYNwz90Q hC92V5NtHaw7gWFvbLOiym61XcNNEGmdGP46eWDAn00zX/lR+nazW4eNP0m2nA4UBRig PGn+gMtNrJoERwapjGnDBiNe3g7mzmHExmo4knnzaH9+6iOfWHAVp6GVB92M1Wv9j5Hv +JjQ== X-Gm-Message-State: ALQs6tBQQMB1Hf2UHX8s+SiH6/JKDXwhVUscpqub9+SGSx4C7TGjBuBx VcQ1yphFNI86cpdcGqFk590zDg== X-Google-Smtp-Source: AIpwx48g4R/ZYfJl/GBlpVd3VFHXmILImAH0klmwG5ylwyFErKcf3Zq0ZupxQju4eBYa+4qeaARHNw== X-Received: by 10.200.82.86 with SMTP id y22mr3185679qtn.167.1523626514991; Fri, 13 Apr 2018 06:35:14 -0700 (PDT) Received: from phe.ftfl.ca.ftfl.ca (hlfxns017vw-47-55-140-73.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.140.73]) by smtp.gmail.com with ESMTPSA id y66sm5196064qky.61.2018.04.13.06.35.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Apr 2018 06:35:13 -0700 (PDT) From: Joseph Mingrone To: Matthias Fechner Cc: Alexey Dokuchaev , Sunpoet Po-Chuan Hsieh , Torsten Zuehlsdorff , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r467193 - in head/www/gitlab: . files References: <201804121833.w3CIXtgW077267@repo.freebsd.org> <431aaec9-51c2-c0c9-7a1f-2f29f79edb5d@fechner.net> <20180413100736.GA32041@FreeBSD.org> Date: Fri, 13 Apr 2018 10:35:11 -0300 In-Reply-To: (Torsten Zuehlsdorff's message of "Fri, 13 Apr 2018 12:10:20 +0200") Message-ID: <86o9inrzzk.fsf@phe.ftfl.ca> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 13:43:47 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Matthias Fechner writes: > Dear sunpoet, > Am 12.04.2018 um 20:33 schrieb Sunpoet Po-Chuan Hsieh: >> Log: >> Fix Gemfile for rubygem-default_value_for 3.1.0 update >> - Bump PORTREVISION for package change >> Modified: >> head/www/gitlab/Makefile >> head/www/gitlab/files/patch-Gemfile > I really enjoy your work and it is totally fine for me, if you upgrade a > gem that you copy the old one and make sure that gitlab uses the old. > (like you did with r467106, thanks a lot for this!) > But please do not start to patch the Gemfile! > This will break gitlab. Have you tested gitlab with this modification? > (for sure not, I reported exactly that version of default_value_for > upstream and they rolled back the change as it broke gitlab, they broke > 3.0.4 and rolled back the modification with 3.0.5, now you changed > gitlab to use the version that for sure will not work!) > Please revert this modification and ask me (the maintainer) before you > start to modify the port I maintain. > Thanks a lot that you understand this. > Gru=C3=9F > Matthias I relate. Sunpoet, I also appreciate your work, but this type of breakage can be frustrating. We need to figure out a solution. > On 13.04.2018 12:07, Alexey Dokuchaev wrote: >> I don't quite understand how/why would anyone in their right mind write >> software than breaks when one of its dependencies have *minor* version >> bump? Is this specific to Gitlab, or the nature of Gemfiles is really >> that broken? This practice seems to be more common and in the extreme case, exact versions of all components are specified. A few examples that come to mind other than Ruby Gems (with Bundler) are node and Haskell's stack. To match what upstream is requesting, I have wondered if the ability to specify maximum versions would be useful. RUN_DEPENDS=3D rubygem-default_value_for>=3D3.0.1<3.1:devel/rubygem-default_value_for The added complexity is probably not worth it for the ability to run this sort of test. devel/rubygem-default_value_for % check_update_breaks_something *** DANGER, DANGER *** www/gitlab requires devel/rubygem-default_value_for = < 3.1 ! A less drastic approach would be to add PORTSCOUT entries to prevent premature Gem port updates. In this case PORTSCOUT=3D limit:^3\.0 in devel/rubygem-default_value_for/Makefile Could this work for everyone? J. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEVbCTpybDiFVxIrrVNqQMg7DW754FAlrQsg9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUACgkQNqQMg7DW 7553Sw/6AsWfnVxheuL561Ym6I9mZWbVH13H73BQWFATMbM3QEeuTPTHFqU452cC 6r2D6jvI5ivSFzyRmOXkHDAk7gcgcO0ysPoCYO6l3aP9XVYD/lZhdzq2PEJ/IqGu PiYrNnMSmin3JDI8RYh03G/D+TkWFY6DWE8R81chJdfPL1HgaHPmorayH7es0v8O MDdJFb5nKlfKR8kAnVN5PSmx41IdbT5GgA/r/deMM0y7mWca+bAty958OJenx2WJ uR3fU8dALlaV/99oSubU0N8S1jyAxnHdxqLewi5KA6eePKwXLHvFRQCR3OUVhj/d K7SL2MjCpZNhW/OAYmN4r9ovTgDlubu6jftYhgck79PcJHAWllXgwLl071GDX/YE CmTN8OuJyY/L4EmAUh7QGBT8pVWX6VF4xJSPlwftFnH6ma7Sg2M25vnqDNXot9gi umu45gonq/78q1MSLYHavSHulAvcJ25Z/EPkKdvyvg2HWgXYQsaFXpR4QOiMnnyc eWW6qR3ZsaV69smWJ5/8Gtkg6anyNCAtiOcwHwoZkvqRs9nQwKqJepNW77nUx3MJ YLkCwsmk6oGnYjyqHhfB0LgrqHmFN2mcJvGBjNSsthDuQznhYqp6H4l02mw8jEpY J6GpVF/tLSktztVrv82ZGDqKZmQSrKFV5I3RQlufiv6owwJtemo= =4SkM -----END PGP SIGNATURE----- --=-=-=--