From owner-freebsd-net@FreeBSD.ORG  Mon Aug  6 12:08:17 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9D693106564A;
	Mon,  6 Aug 2012 12:08:17 +0000 (UTC)
	(envelope-from luigi@onelab2.iet.unipi.it)
Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238])
	by mx1.freebsd.org (Postfix) with ESMTP id 1C89C8FC14;
	Mon,  6 Aug 2012 12:08:16 +0000 (UTC)
Received: by onelab2.iet.unipi.it (Postfix, from userid 275)
	id 6B9577300A; Mon,  6 Aug 2012 14:28:25 +0200 (CEST)
Date: Mon, 6 Aug 2012 14:28:25 +0200
From: Luigi Rizzo <rizzo@iet.unipi.it>
To: current@freebsd.org, net@freebsd.org
Message-ID: <20120806122825.GA96329@onelab2.iet.unipi.it>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4.2.3i
Cc: 
Subject: [RFC] changes in struct dn_pkt_tag ?
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Aug 2012 12:08:17 -0000

I just realized that the struct dn_pkt_tag is 232 bytes,
with the majority of space taken by an unused field,
struct _ip6dn_args (192 bytes), which I'd like to remove.

The structure constitutes the body of a PACKET_TAG_DUMMYNET, is
defined in sys/netinet/ipfw/ip_dn_io.c and private to the dummynet
module.  Do I still need to bump __FreeBSD_version if i remove the
unused field from the structure ?

Related to this, struct _ip6dn_args is also an unused part of
struct ip_fw_args, which however is used by other ipfw clients
such as ng_ipfw, so i am a bit reluctant to "fix" that too.

cheers
luigi