From owner-freebsd-audit  Wed May 30 19:37:43 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from iatl0x01.coxmail.com (iatl0x02.coxmail.com [206.157.225.11])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5E44637B424; Wed, 30 May 2001 19:37:40 -0700 (PDT)
	(envelope-from mheffner@novacoxmail.com)
Received: from enterprise.muriel.penguinpowered.com ([208.138.198.178])
          by iatl0x01.coxmail.com
          (InterMail vK.4.03.02.00 201-232-124 license 85f4f10023be2bd3bce00b3a38363ea2)
          with ESMTP
          id <20010531023714.MAIU19826.iatl0x01@enterprise.muriel.penguinpowered.com>;
          Wed, 30 May 2001 22:37:14 -0400
Message-ID: <XFMail.20010530223446.mheffner@novacoxmail.com>
X-Mailer: XFMail 1.4.7 on FreeBSD
X-Priority: 3 (Normal)
MIME-Version: 1.0
Content-Type: multipart/signed;
 boundary="_=XFMail.1.4.7.FreeBSD:20010530223446:495=_";
 micalg=pgp-md5; protocol="application/pgp-signature"
In-Reply-To: <B739651A.B9D%mike@q9media.com>
Date: Wed, 30 May 2001 22:34:46 -0400 (EDT)
Reply-To: Mike Heffner <mheffner@vt.edu>
From: Mike Heffner <mheffner@novacoxmail.com>
To: Mike Barcroft <mike@q9media.com>
Subject: RE: whois(1) patch
Cc: phk@freebsd.org, freebsd-audit@freebsd.org
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

This message is in MIME format
--_=XFMail.1.4.7.FreeBSD:20010530223446:495=_
Content-Type: text/plain; charset=us-ascii


On 29-May-2001 Mike Barcroft wrote:
| 
| Please review the patch at the following URL:
| http://testbed.q9media.net/freebsd/whois.patch
| 
| 
| It does the following:
| 
|  o Silence warnings and set WARNS=2
|  o Fix two memory leaks
|  o asprint -> strdup where appropriate
|  o calloc/strcpy/strcat -> aprintf
|  o Convert to ANSI C to avoid having to prototype main()

You don't need the space between (void) and asprintf(). Also, I think dd had a
patch for gcc to quiet the warning about main() not having a prototype, so I
don't know if the ANSI-fication is truly needed. Otherwise, looks alright ;)

Mike

-- 
  Mike Heffner               <mheffner@vt.edu>
  Fredericksburg, VA       <mikeh@FreeBSD.org>
      http://filebox.vt.edu/users/mheffner


--_=XFMail.1.4.7.FreeBSD:20010530223446:495=_
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (FreeBSD)
Comment: For info see http://www.gnupg.org

iD8DBQE7Fa3FFokZQs3sv5kRAhvyAJ0cPsKqhzBNkw8v4CXqi9RVA8LJMwCgkKLD
i9HNo2yIHd62cxQC4B5r8QM=
=8m0m
-----END PGP SIGNATURE-----

--_=XFMail.1.4.7.FreeBSD:20010530223446:495=_--
End of MIME message

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message