Date: Fri, 14 Apr 2017 15:22:23 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 218592] [patch] fsck_ffs(8): incorrect bounds check in preen mode when softdep is enabled Message-ID: <bug-218592-8-yGrrVTRVZZ@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-218592-8@https.bugs.freebsd.org/bugzilla/> References: <bug-218592-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218592 --- Comment #4 from commit-hook@freebsd.org --- A commit references this bug: Author: kib Date: Fri Apr 14 15:22:01 UTC 2017 New revision: 316852 URL: https://svnweb.freebsd.org/changeset/base/316852 Log: In fsck_ffs pass1, prevent the inosused variable from wrapping. The loop that scans the used inode map when soft updates is in use assumes that the inosused variable is signed. However, ino_t is unsigned, so the loop invariant is incorrect and the check for inosused wrapping to < 0 can never be true. Instead of checking for wrap after the fact just prevent it from happening in the first place. PR: 218592 Submitted by: Todd Miller <todd.miller@courtesan.com> Reviewed by: mckusick MFC after: 1 week Changes: head/sbin/fsck_ffs/pass1.c --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-218592-8-yGrrVTRVZZ>