Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 2 Dec 2012 18:03:12 +0100
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        Andriy Gapon <avg@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r243762 - head/sys/cddl/contrib/opensolaris/uts/common/fs
Message-ID:  <20121202170312.GG1399@garage.freebsd.pl>
In-Reply-To: <201212011812.qB1ICt7O063719@svn.freebsd.org>
References:  <201212011812.qB1ICt7O063719@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--DWg365Y4B18r8evw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Dec 01, 2012 at 06:12:55PM +0000, Andriy Gapon wrote:
> Author: avg
> Date: Sat Dec  1 18:12:55 2012
> New Revision: 243762
> URL: http://svnweb.freebsd.org/changeset/base/243762
>=20
> Log:
>   gfs_file_inactive: replace bad code with ugly code
>  =20
>   Also, make it explicit that V_XATTRDIR is not properly supported in gfs
>   code yet.
>  =20
>   The bad code was plain incorrect: (a) it spoiled handling of v_usecount
>   reaching zero and (b) it leaked v_holdcnt.
>  =20
>   The ugly code employs potentially unsafe locking tricks.
>  =20
>   Ideally we should separate vnode lifecycle and gfs node lifecycle.
>   A gfs node should have its own reference count where its child nodes
>   should be accounted.

Very good you are touching this:) If you verify if it works, you should
try .zfs/ directory when it is visible and not visible through local
file system and through NFS. All those cases have their own bugs in the
past.

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl

--DWg365Y4B18r8evw
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlC7ic8ACgkQForvXbEpPzSr5gCdGn7Fp8EmPpy3lJDUYUqX7ZAK
F3MAn1ARoVCS1WO9ekxtjyJCIXkBBmOU
=WcP1
-----END PGP SIGNATURE-----

--DWg365Y4B18r8evw--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121202170312.GG1399>