From owner-svn-src-all@FreeBSD.ORG  Sun Dec  2 17:02:02 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id DF69B29B;
 Sun,  2 Dec 2012 17:02:02 +0000 (UTC)
 (envelope-from pawel@dawidek.net)
Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72])
 by mx1.freebsd.org (Postfix) with ESMTP id 9A7D08FC0C;
 Sun,  2 Dec 2012 17:02:02 +0000 (UTC)
Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149])
 by mail.dawidek.net (Postfix) with ESMTPSA id B4CD8190;
 Sun,  2 Dec 2012 18:00:01 +0100 (CET)
Date: Sun, 2 Dec 2012 18:03:12 +0100
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Andriy Gapon <avg@FreeBSD.org>
Subject: Re: svn commit: r243762 -
 head/sys/cddl/contrib/opensolaris/uts/common/fs
Message-ID: <20121202170312.GG1399@garage.freebsd.pl>
References: <201212011812.qB1ICt7O063719@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="DWg365Y4B18r8evw"
Content-Disposition: inline
In-Reply-To: <201212011812.qB1ICt7O063719@svn.freebsd.org>
X-OS: FreeBSD 10.0-CURRENT amd64
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Dec 2012 17:02:03 -0000


--DWg365Y4B18r8evw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Dec 01, 2012 at 06:12:55PM +0000, Andriy Gapon wrote:
> Author: avg
> Date: Sat Dec  1 18:12:55 2012
> New Revision: 243762
> URL: http://svnweb.freebsd.org/changeset/base/243762
>=20
> Log:
>   gfs_file_inactive: replace bad code with ugly code
>  =20
>   Also, make it explicit that V_XATTRDIR is not properly supported in gfs
>   code yet.
>  =20
>   The bad code was plain incorrect: (a) it spoiled handling of v_usecount
>   reaching zero and (b) it leaked v_holdcnt.
>  =20
>   The ugly code employs potentially unsafe locking tricks.
>  =20
>   Ideally we should separate vnode lifecycle and gfs node lifecycle.
>   A gfs node should have its own reference count where its child nodes
>   should be accounted.

Very good you are touching this:) If you verify if it works, you should
try .zfs/ directory when it is visible and not visible through local
file system and through NFS. All those cases have their own bugs in the
past.

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl

--DWg365Y4B18r8evw
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlC7ic8ACgkQForvXbEpPzSr5gCdGn7Fp8EmPpy3lJDUYUqX7ZAK
F3MAn1ARoVCS1WO9ekxtjyJCIXkBBmOU
=WcP1
-----END PGP SIGNATURE-----

--DWg365Y4B18r8evw--