From owner-svn-src-user@FreeBSD.ORG  Thu Feb  4 09:04:35 2010
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 65F6A106566C;
	Thu,  4 Feb 2010 09:04:35 +0000 (UTC)
	(envelope-from luigi@onelab2.iet.unipi.it)
Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238])
	by mx1.freebsd.org (Postfix) with ESMTP id 200228FC28;
	Thu,  4 Feb 2010 09:04:34 +0000 (UTC)
Received: by onelab2.iet.unipi.it (Postfix, from userid 275)
	id 9550A730A1; Thu,  4 Feb 2010 10:13:16 +0100 (CET)
Date: Thu, 4 Feb 2010 10:13:16 +0100
From: Luigi Rizzo <rizzo@iet.unipi.it>
To: Roman Divacky <rdivacky@freebsd.org>
Message-ID: <20100204091316.GC81601@onelab2.iet.unipi.it>
References: <201002040724.o147OD9l046782@svn.freebsd.org>
	<20100204075034.GA30179@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100204075034.GA30179@freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: Luigi Rizzo <luigi@freebsd.org>, src-committers@freebsd.org,
	svn-src-user@freebsd.org
Subject: Re: svn commit: r203481 - user/luigi/ipfw3-head/sys/netinet/ipfw
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
	src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Feb 2010 09:04:35 -0000

On Thu, Feb 04, 2010 at 08:50:34AM +0100, Roman Divacky wrote:
> On Thu, Feb 04, 2010 at 07:24:13AM +0000, Luigi Rizzo wrote:
> > Author: luigi
> > Date: Thu Feb  4 07:24:13 2010
> > New Revision: 203481
> > URL: http://svn.freebsd.org/changeset/base/203481
> > 
> > Log:
> >   portability fix for compilers that do not have C99 initializers
> 
> C99 in kernel is a must and has been for a long time... I dont think
> that obfuscating obvious code to be able to support ancient compiler(s)
> is worth it...

unfortunately this code is shared among multiple platforms (including
a Windows NDIS driver and the only way i know to do it is using
MSVC), and keeping separate distributions is too expensive in terms
of mainteinance.

I tried for almost one year not to pollute the code in the tree with
#ifdefs and intrusive portability tricks, but the only effect was
to slow down development and fixes to the FreeBSD code.

I'll try and see if i can find some other tricks to achieve the same
result before the code is merged into HEAD.

cheers
luigi