From owner-freebsd-current@FreeBSD.ORG Thu Apr 15 15:54:19 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A0DEB1065670; Thu, 15 Apr 2010 15:54:19 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from mail-bw0-f214.google.com (mail-bw0-f214.google.com [209.85.218.214]) by mx1.freebsd.org (Postfix) with ESMTP id BDB058FC1C; Thu, 15 Apr 2010 15:54:18 +0000 (UTC) Received: by bwz6 with SMTP id 6so1373681bwz.13 for ; Thu, 15 Apr 2010 08:54:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:cc:content-type; bh=7MSV8G5MvMvycol5HD5FXZe+lHE3NoP3FXwoooSXroY=; b=u5hUtuJxbnHhBNpys9iqZAW8PxtCd9ngtV02nSrd6BFo5nn7ktFhdVT1K/evKal2o/ IUjAt/gYnGHqf8YBJDoZ+SNzx7ZVGwvNLRORe1xeW9yOXFkJOwxG8ZqSItSA7PmY2ynf otQkmwaEU6z72RxdsFMI1d/CMCo6JGJWzmblE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=dwBDKfHgXb6KM9V9BqL2e+uChMgWrB46uwoe8hs5+4H0AA2hfkDvKqy8wLWhiIY9qr Jy+Ud4M0TX7wjTTAhXkjsjOdmUIn8aZcoypRbk87PKA8el0AKhhkL5nCE9r0oa/4NGgB 5oI3NvFyIyUxscilyiM/WRExMteKyItl6njME= MIME-Version: 1.0 Received: by 10.204.47.232 with HTTP; Thu, 15 Apr 2010 08:54:17 -0700 (PDT) In-Reply-To: <4BC71778.40505@freebsd.org> References: <20100312171758.GB31089@dragon.NUXI.org> <201004071549.41672.jhb@freebsd.org> <201004150913.50097.jhb@freebsd.org> <4BC71778.40505@freebsd.org> Date: Thu, 15 Apr 2010 19:54:17 +0400 Received: by 10.204.81.164 with SMTP id x36mr262736bkk.162.1271346857488; Thu, 15 Apr 2010 08:54:17 -0700 (PDT) Message-ID: From: pluknet To: Nathan Whitehorn Content-Type: multipart/mixed; boundary=0016e6dd89d9d3b0a604844881ac Cc: freebsd-current@freebsd.org Subject: Re: HEADS UP: COMPAT_IA32 renamed COMPAT_FREEBSD32 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Apr 2010 15:54:19 -0000 --0016e6dd89d9d3b0a604844881ac Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 15 April 2010 17:41, Nathan Whitehorn wrote: > On 04/15/10 08:13, John Baldwin wrote: >> >> On Thursday 15 April 2010 6:06:24 am pluknet wrote: >> >>> >>> On 7 April 2010 23:49, John Baldwin =A0wrote: >>> >>>> >>>> On Tuesday 06 April 2010 11:24:21 am Nathan Whitehorn wrote: >>>> >>>>> >>>>> pluknet wrote: >>>>> >>>>>> >>>>>> Hi, >>>>>> >>>>>> the interesting part for me is how to properly assert now a value of >>>>>> >> >> e.g. >> >>>>>> >>>>>> KINFO_PROC_SIZE varying on err.. different COMPAT_FREEBSD32 arches >>>>>> (say, FreeBSD would have _kern_proc FreeBSD32 compat layer for >>>>>> >> >> top/ps/). >> >>>>>> >>>>>> >>>>> >>>>> Probably the cleanest thing would be to set KINFO_PROC_SIZE in >>>>> machine/proc.h instead of where it is now, and then also define a >>>>> KINFO_PROC32_SIZE or something in the same place. Also, that would be= a >>>>> really nice feature. >>>>> >>>> >>>> Yes, I think this sounds like the best approach. >>>> >>>> >>> >>> Something quick& =A0not clean (well, it passes universe) attached. >>> So, don't shoot me, please ;-). >>> It's unclear how to convert those mips o32/n32/o64/n64 though. >>> I had to make definitions out of _KERNEL visibility as far as >>> =A0is included from =A0in !_KERNEL only too. >>> >> >> Just one suggestion: don't make KINFO_PROC32 #define depenedent on >> COMPAT_FREEBSD32. =A0It should just be always defined. =A0I think that i= s the >> approach Nathan used for the 32-bit ELF machine type. >> > > I agree. There's no harm in making it a global definition. You also need = a > KINFO_PROC32 for ia64, which also implements i386 compatibility. Other th= an > that, the patch looks good to me. > -Nathan > Thanks for your suggestions. --=20 wbr, pluknet --0016e6dd89d9d3b0a604844881ac Content-Type: application/octet-stream; name="KINFO_PROC_SIZE_md.2.diff" Content-Disposition: attachment; filename="KINFO_PROC_SIZE_md.2.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g81r1goa0 SW5kZXg6IHN5cy9hcm0vaW5jbHVkZS9wcm9jLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL2FybS9pbmNs dWRlL3Byb2MuaAkocmV2aXNpb24gMjA2MzM4KQorKysgc3lzL2FybS9pbmNsdWRlL3Byb2MuaAko d29ya2luZyBjb3B5KQpAQCAtNjAsNCArNjAsNiBAQAogCXZvaWQJKm1kX3NpZ3RyYW1wOwogfTsK IAorI2RlZmluZSBLSU5GT19QUk9DX1NJWkUgNzkyCisKICNlbmRpZiAvKiAhX01BQ0hJTkVfUFJP Q19IXyAqLwpJbmRleDogc3lzL3Bvd2VycGMvaW5jbHVkZS9wcm9jLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g c3lzL3Bvd2VycGMvaW5jbHVkZS9wcm9jLmgJKHJldmlzaW9uIDIwNjMzOCkKKysrIHN5cy9wb3dl cnBjL2luY2x1ZGUvcHJvYy5oCSh3b3JraW5nIGNvcHkpCkBAIC00Niw0ICs0Niw2IEBACiBzdHJ1 Y3QgbWRwcm9jIHsKIH07CiAKKyNkZWZpbmUgS0lORk9fUFJPQ19TSVpFIDc2OAorCiAjZW5kaWYg LyogIV9NQUNISU5FX1BST0NfSF8gKi8KSW5kZXg6IHN5cy9zcGFyYzY0L2luY2x1ZGUvcHJvYy5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIHN5cy9zcGFyYzY0L2luY2x1ZGUvcHJvYy5oCShyZXZpc2lvbiAyMDYz MzgpCisrKyBzeXMvc3BhcmM2NC9pbmNsdWRlL3Byb2MuaAkod29ya2luZyBjb3B5KQpAQCAtNTEs NCArNTEsNiBAQAogCXZvaWQJKm1kX3NpZ3RyYW1wOwogfTsKIAorI2RlZmluZSBLSU5GT19QUk9D X1NJWkUgMTA4OAorCiAjZW5kaWYgLyogIV9NQUNISU5FX1BST0NfSF8gKi8KSW5kZXg6IHN5cy9p YTY0L2luY2x1ZGUvcHJvYy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHN5cy9pYTY0L2luY2x1ZGUvcHJvYy5o CShyZXZpc2lvbiAyMDYzMzgpCisrKyBzeXMvaWE2NC9pbmNsdWRlL3Byb2MuaAkod29ya2luZyBj b3B5KQpAQCAtMzgsNCArMzgsNyBAQAogCWludAkJX19kdW1teTsJLyogQXZvaWQgaGF2aW5nIGFu IGVtcHR5IHN0cnVjdC4gKi8KIH07CiAKKyNkZWZpbmUgS0lORk9fUFJPQ19TSVpFIDEwODgKKyNk ZWZpbmUgS0lORk9fUFJPQzMyX1NJWkUgNzY4CisKICNlbmRpZiAvKiAhX01BQ0hJTkVfUFJPQ19I XyAqLwpJbmRleDogc3lzL21pcHMvaW5jbHVkZS9wcm9jLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL21p cHMvaW5jbHVkZS9wcm9jLmgJKHJldmlzaW9uIDIwNjMzOCkKKysrIHN5cy9taXBzL2luY2x1ZGUv cHJvYy5oCSh3b3JraW5nIGNvcHkpCkBAIC02OSw0ICs2OSwxMCBAQAogdm9pZAltaXBzX2NwdV9z d2l0Y2goc3RydWN0IHRocmVhZCAqLCBzdHJ1Y3QgdGhyZWFkICosIHN0cnVjdCBtdHggKik7CiB2 b2lkCW1pcHNfY3B1X3Rocm93KHN0cnVjdCB0aHJlYWQgKiwgc3RydWN0IHRocmVhZCAqKTsKIAor I2lmZGVmIF9fbWlwc19uNjQKKyNkZWZpbmUgS0lORk9fUFJPQ19TSVpFIDEwODgKKyNlbHNlCisj ZGVmaW5lIEtJTkZPX1BST0NfU0laRSA4MTYKKyNlbmRpZgorCiAjZW5kaWYJLyogIV9NQUNISU5F X1BST0NfSF8gKi8KSW5kZXg6IHN5cy9zdW40di9pbmNsdWRlL3Byb2MuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBzeXMvc3VuNHYvaW5jbHVkZS9wcm9jLmgJKHJldmlzaW9uIDIwNjMzOCkKKysrIHN5cy9zdW40 di9pbmNsdWRlL3Byb2MuaAkod29ya2luZyBjb3B5KQpAQCAtNTEsNCArNTEsNiBAQAogCXZvaWQJ Km1kX3NpZ3RyYW1wOwogfTsKIAorI2RlZmluZSBLSU5GT19QUk9DX1NJWkUgMTA4OAorCiAjZW5k aWYgLyogIV9NQUNISU5FX1BST0NfSF8gKi8KSW5kZXg6IHN5cy9pMzg2L2luY2x1ZGUvcHJvYy5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIHN5cy9pMzg2L2luY2x1ZGUvcHJvYy5oCShyZXZpc2lvbiAyMDYzMzgp CisrKyBzeXMvaTM4Ni9pbmNsdWRlL3Byb2MuaAkod29ya2luZyBjb3B5KQpAQCAtNTcsNiArNTcs OCBAQAogCXN0cnVjdCBwcm9jX2xkdCAqbWRfbGR0OwkvKiAodCkgcGVyLXByb2Nlc3MgbGR0ICov CiB9OwogCisjZGVmaW5lIEtJTkZPX1BST0NfU0laRSA3NjgKKwogI2lmZGVmCV9LRVJORUwKIAog LyogR2V0IHRoZSBjdXJyZW50IGtlcm5lbCB0aHJlYWQgc3RhY2sgdXNhZ2UuICovCkluZGV4OiBz eXMvYW1kNjQvaW5jbHVkZS9wcm9jLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL2FtZDY0L2luY2x1ZGUv cHJvYy5oCShyZXZpc2lvbiAyMDYzMzgpCisrKyBzeXMvYW1kNjQvaW5jbHVkZS9wcm9jLmgJKHdv cmtpbmcgY29weSkKQEAgLTUzLDYgKzUzLDkgQEAKIAlzdHJ1Y3Qgc3lzdGVtX3NlZ21lbnRfZGVz Y3JpcHRvciBtZF9sZHRfc2Q7CiB9OwogCisjZGVmaW5lIEtJTkZPX1BST0NfU0laRSAxMDg4Cisj ZGVmaW5lIEtJTkZPX1BST0MzMl9TSVpFIDc2OAorCiAjaWZkZWYJX0tFUk5FTAogCiAvKiBHZXQg dGhlIGN1cnJlbnQga2VybmVsIHRocmVhZCBzdGFjayB1c2FnZS4gKi8KSW5kZXg6IHN5cy9zeXMv dXNlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIHN5cy9zeXMvdXNlci5oCShyZXZpc2lvbiAyMDYzMzgpCisr KyBzeXMvc3lzL3VzZXIuaAkod29ya2luZyBjb3B5KQpAQCAtODcsMzQgKzg3LDExIEBACiAjZGVm aW5lCUtJX05TUEFSRV9MT05HCTEyCiAjZGVmaW5lCUtJX05TUEFSRV9QVFIJNwogCi0jaWZkZWYg X19hbWQ2NF9fCi0jZGVmaW5lCUtJTkZPX1BST0NfU0laRQkxMDg4Ci0jZW5kaWYKLSNpZmRlZiBf X2FybV9fCi0jZGVmaW5lCUtJTkZPX1BST0NfU0laRQk3OTIKLSNlbmRpZgotI2lmZGVmIF9faWE2 NF9fCi0jZGVmaW5lCUtJTkZPX1BST0NfU0laRSAxMDg4Ci0jZW5kaWYKLSNpZmRlZiBfX2kzODZf XwotI2RlZmluZQlLSU5GT19QUk9DX1NJWkUJNzY4Ci0jZW5kaWYKLSNpZmRlZiBfX21pcHNfXwot I2lmZGVmIF9fbWlwc19uNjQKLSNkZWZpbmUJS0lORk9fUFJPQ19TSVpFCTEwODgKLSNlbHNlCi0j ZGVmaW5lCUtJTkZPX1BST0NfU0laRQk4MTYKLSNlbmRpZgotI2VuZGlmCi0jaWZkZWYgX19wb3dl cnBjX18KLSNkZWZpbmUJS0lORk9fUFJPQ19TSVpFCTc2OAotI2VuZGlmCi0jaWZkZWYgX19zcGFy YzY0X18KLSNkZWZpbmUJS0lORk9fUFJPQ19TSVpFIDEwODgKLSNlbmRpZgorI2lmbmRlZiBfS0VS TkVMCiAjaWZuZGVmIEtJTkZPX1BST0NfU0laRQogI2Vycm9yICJVbmtub3duIGFyY2hpdGVjdHVy ZSIKICNlbmRpZgorI2VuZGlmIC8qICFfS0VSTkVMICovCiAKICNkZWZpbmUJV01FU0dMRU4JOAkJ Lyogc2l6ZSBvZiByZXR1cm5lZCB3Y2hhbiBtZXNzYWdlICovCiAjZGVmaW5lCUxPQ0tOQU1FTEVO CTgJCS8qIHNpemUgb2YgcmV0dXJuZWQgbG9jayBuYW1lICovCg== --0016e6dd89d9d3b0a604844881ac--