From owner-svn-src-head@freebsd.org Tue Apr 17 18:25:43 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 14912F90169 for ; Tue, 17 Apr 2018 18:25:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A2BFC735EA for ; Tue, 17 Apr 2018 18:25:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22c.google.com with SMTP id a7so7625084ioc.12 for ; Tue, 17 Apr 2018 11:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=RXueKUvQiUsZctaJGoQhq0rXXNPr0SVf6vJEa9/Xb2o=; b=SbrcXfiF38YLnxuaY9ADzE52pMrR9M3pk1ahdX5x+oDYuk4yc2afwWo5NwzPz6IFSt 3anHTP/BoJ4xtzDd7islXeh3io5X7qviLF1KpxzRavs2XPSO65z2i8q8pZN2vt6QxaKt KO/dIziKOi9rYiNTzA9lC/FPN2rJRzMre+vlmFttZdEQ5x1u5PDTjo7E48noEnng7Hb1 whbfyzjAtXVivxz0NeFmAAsmf+xP0fkYpqgrpWeeGNHU2poF+cGLLia9oxwp4l3UCOtV Yeiaji1HlUVWz/8LHkv372lCgdi1F5FZtqTS3a/7m5WKmCithH5hhtbarniKo4nW+qUQ /PKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=RXueKUvQiUsZctaJGoQhq0rXXNPr0SVf6vJEa9/Xb2o=; b=s6jegAAc0fJHcrQ7GfJWtPNLmcgILmnpKJKa8f9mirfWmelPzL+pO2PSQnv/UzUL3R hNQTLnilvuNPmfRSKEq2DQRLeRXZUm6TVbFwAkt462ejVXLhhVvg347yFJ/+iB3jMZEL s8BIlYSAobgV8WeVfItQNIjx9nXGj4oNcHxfsWQ3VXBnojQOVJ1JSQR7lFYAFGEp1uo9 b/JL5+HDVMpqj4RIUX3cxzxFk34p7Uuov0yLU/hKRSY/WeVRA+l2z/FuTYrdPgiGQneJ WIr8fpaT6LUTtEvvnm8eSNeD1QCPKI4z+bI1P+WpAHL62PS11lHr6zLOM9D2pWB1zyBN dqWQ== X-Gm-Message-State: ALQs6tCe95Ec1lOjHXjPT4GRhvk+YNG3s8zuKIuFyhw99K94xfA2ua3L OKck1OzTBL8VholaMLOthcnSm6z9NvFQ2N/Rs7vKqA== X-Google-Smtp-Source: AIpwx4+JO0jM0Fja5x+fE2shxY/g7Be6OfRxe9KxTct3Ggg7cro+Q1I4CLoaEr0l93rDbthOmtU4xsCJVi/RQQMvbyY= X-Received: by 10.107.56.70 with SMTP id f67mr3135728ioa.117.1523989541763; Tue, 17 Apr 2018 11:25:41 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:a604:0:0:0:0:0 with HTTP; Tue, 17 Apr 2018 11:25:41 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <3010482.A3g1Uy1uGA@ralph.baldwin.cx> References: <201804171646.w3HGk9vn040646@repo.freebsd.org> <3010482.A3g1Uy1uGA@ralph.baldwin.cx> From: Warner Losh Date: Tue, 17 Apr 2018 12:25:41 -0600 X-Google-Sender-Auth: bYkxuy9VpSG-1_h-t3sRdfAr9qU Message-ID: Subject: Re: svn commit: r332652 - in head/sys: conf dev/puc modules/puc To: John Baldwin Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 18:25:43 -0000 On Tue, Apr 17, 2018 at 11:20 AM, John Baldwin wrote: > On Tuesday, April 17, 2018 04:46:09 PM Warner Losh wrote: > > Author: imp > > Date: Tue Apr 17 16:46:08 2018 > > New Revision: 332652 > > URL: https://svnweb.freebsd.org/changeset/base/332652 > > > > Log: > > Add PNP info to the PCI attahement of the puc driver. > > > > Adjust sys/conf/files and sys/modules/puc/Makefile to omit > > pucdata.c now tht it's included by puc_pci.c. > > > > Submitted by: Lakhan Shiva Kamireddy (with build fixes by me) > > Pull Request: https://github.com/freebsd/freebsd/pull/136 > > If you are going to #include it you can remove the terminator entry > and use nitems() in puc_pci_match instead. That will also remove the > need for the - 1 hack in the MODULE_PNP_INFO line. > Good suggestion... Warner