From owner-svn-ports-all@freebsd.org Fri Jul 10 16:08:25 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B576736CC60; Fri, 10 Jul 2020 16:08:25 +0000 (UTC) (envelope-from tijl@freebsd.org) Received: from mailrelay117.isp.belgacom.be (mailrelay117.isp.belgacom.be [195.238.20.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "relay.skynet.be", Issuer "GlobalSign RSA OV SSL CA 2018" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B3Hyc68xJz4mjw; Fri, 10 Jul 2020 16:08:24 +0000 (UTC) (envelope-from tijl@freebsd.org) IronPort-SDR: NAWVTFN5qKCBUjZt3dbf3tbuJwONNTH9tPxkAtCX42bjzj8T1XRSVFtg/RO3I/99aoG5h9psml +nBqcc4ytxq542eszcQ7NPMKu3OROkLOB9NQOl8m+3iuiS1Dwu1lzJ5E2ADiASchAqz4p0WzS6 x3d4HZcnRKp5sYbgvI1yiARwEIJgKsfd5iUfVLPelGrayXOF6uTvMhIdFTDKPmvFzXk+oeh3MV TO9gXx3Ll2E7I2KV6xVMg+8DRG600t6QAstGQMfYylT1aCCLQWEaBjr0JlZdokVAD023BFMV5J lBw= X-Belgacom-Dynamic: yes IronPort-PHdr: =?us-ascii?q?9a23=3AjmOIeRWLNhbFdjGkOPy/1+hRxLLV8LGtZVwlr6?= =?us-ascii?q?E/grcLSJyIuqrYZRWFvqdThVPEFb/W9+hDw7KP9fy5BypauN3Y6ChKMMQVEU?= =?us-ascii?q?Nc1INOx01oKfXGIHWzFOTtYS0+EZYKf35e1Fb/D3JoHt3jbUbZuHy44G1aMB?= =?us-ascii?q?z+MQ1oOra9QdaK3Iy42O+o5pLcfRhDiiajbrNuNhW2qhjautULjYd4Jas91x?= =?us-ascii?q?rErmFWd+hLym9kOE6fkwrh7cu04JJv7j5ctv08+8NAS6n2Y7g0QblFBzk6Lm?= =?us-ascii?q?4549HmuwPeRgWV/HscVWsWkhtMAwfb6RzxQ4n8vCjnuOdjwSeWJcL5Q6w6Vj?= =?us-ascii?q?Sk9KdrVQTniDwbOD4j8WHYkdJ/gaRGqx+8vRN/worUYIaINPpie67WYN0XSX?= =?us-ascii?q?ZdUstXSidMBJ63YYkSAOobJetWoYnzqUUToxW9BwasCuzgxSNHiHLtwa030f?= =?us-ascii?q?4sHR3a0AA8Ad4DtmnfotXvNKcVVOC41LfGzzDHb/hLxzr974/Icgs/rvGJR7?= =?us-ascii?q?1wd9HRwlQoGgPZj1WQq4jlMiiV2OQXrWeU8fdtW/+hhWI9rAFxuDevy94qh4?= =?us-ascii?q?LUiY0b1krK+j9lwIYpO9K4Ukh7bMakHZZOty+XNIV4T8whTmx0uCg31qELtJ?= =?us-ascii?q?G1cSUW1ZgpyR7SZuCFfoWL4x/tW+ScLzl6iX54dryxiRm8/Euhx+PyUMS/zV?= =?us-ascii?q?hEri1AktbWt3AN0QTe6sadSvRj4Eiuwi2P2B3J5uFDO0A0mrLXKpEgwr4olp?= =?us-ascii?q?ofq0PDHjX5mEjwkaSYdV0k9/Cr5uj6eLnquJCRO5NuhgzxMKkigNGzDOA8Pw?= =?us-ascii?q?UIQmOV4/6z1Kf58k38WLhKi/o2nbTHv53CPsQbo7K5AxdS0oY+9xazFzem38?= =?us-ascii?q?ocnXkANF9FewiIj4zoO1HLPv/4F/C/j06wkDdqxfDGOqftDYnKLnjEi7fuY7?= =?us-ascii?q?N95FRayAoo19xf4IhUCr4ZLPLyXE/+qsDYAwc6PgCp2errFtpw2p8EVW+AAK?= =?us-ascii?q?KVKr7evFuM6+43JumDfo4VuDLzK/g/4P7uiGc0mUMcfamr2Zsac364Hu54LE?= =?us-ascii?q?qHenXsmcoOHX0NvgokQ+zmkEeCXiJLZ3auQ6I84Sk2CJm4DYfFX4ytmLuB3D?= =?us-ascii?q?2nHp1Nf2xGCk6DHm31eIifVfcMcjydLdF6nTwfSLetUYgh1QuhtAXi0bpoMv?= =?us-ascii?q?LU+jEEtZLkzNV1/PPTlRcr+TxsCMSdyX2NT3ptkmwSQz822LtyoUJnylidz6?= =?us-ascii?q?d3mOdYGsFJ6/NOSAc6OobWz/ZmBNDqRgLBYtCJRU6+QtWhGzExUskxz8YSbE?= =?us-ascii?q?Z6HtWiixHD3za2A7ALjbyLH4c58qzG33fvOcly0G3G27Q7g1khWMtPOnWshr?= =?us-ascii?q?Rj+AjLG47Jj0KZmr6sdasGwSHC6WeCwHGAvEFCTgF/T77KXWsCaUfMqtT5/E?= =?us-ascii?q?zCHPeSDuEMMhFA0tKDI60CVdDollpLXv3uIpyKZWu9l3aYKwyFy5m3QMztYW?= =?us-ascii?q?pLjwvHD01Rr+cXtV2BMhMzAy6nuCqKED1sEXrBeU7h29JS7nShQRlnnEmxc0?= =?us-ascii?q?R92u/tqVYujvuGRqZL0w=3D=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2BWAADrkQhf/8cv8FFgGwEBAQEBAQE?= =?us-ascii?q?BBQEBARIBAQEDAwEBAUAHgTIDAQEBCwEBgwMUVAFJFY00hgaCEIsCkQYLAQE?= =?us-ascii?q?BAQEBAQEBKwwEAQGETQKCFyU3Bg4CAwEBAQMCBQEBBgEBAQEBAQUEAYYOOQx?= =?us-ascii?q?DARABgWIigxcBBTocIxALDgYELlcGE4MngwALqjiBNIQ6AQsBgQqEB4EFgTg?= =?us-ascii?q?BjQqCAIERgxA+hD2FdgSaPppZgmeIT5B3L4QNmxmFPJZHlmGBe00wCIMkCUc?= =?us-ascii?q?ZDY4qF4Ykgj6FRD8DMDcCBggBAQMJiEqHSgEB?= X-IPAS-Result: =?us-ascii?q?A2BWAADrkQhf/8cv8FFgGwEBAQEBAQEBBQEBARIBAQEDA?= =?us-ascii?q?wEBAUAHgTIDAQEBCwEBgwMUVAFJFY00hgaCEIsCkQYLAQEBAQEBAQEBKwwEA?= =?us-ascii?q?QGETQKCFyU3Bg4CAwEBAQMCBQEBBgEBAQEBAQUEAYYOOQxDARABgWIigxcBB?= =?us-ascii?q?TocIxALDgYELlcGE4MngwALqjiBNIQ6AQsBgQqEB4EFgTgBjQqCAIERgxA+h?= =?us-ascii?q?D2FdgSaPppZgmeIT5B3L4QNmxmFPJZHlmGBe00wCIMkCUcZDY4qF4Ykgj6FR?= =?us-ascii?q?D8DMDcCBggBAQMJiEqHSgEB?= Received: from 199.47-240-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.240.47.199]) by relay.skynet.be with ESMTP; 10 Jul 2020 18:08:22 +0200 Received: from localhost (localhost [127.0.0.1]) by kalimero.tijl.coosemans.org (8.15.2/8.15.2) with ESMTP id 06AG8LME014522; Fri, 10 Jul 2020 18:08:21 +0200 (CEST) (envelope-from tijl@FreeBSD.org) Date: Fri, 10 Jul 2020 18:08:21 +0200 From: =?UTF-8?B?VMSzbA==?= Coosemans To: Christian Weisgerber Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r541352 - head/audio/libvorbis Message-ID: <20200710180821.135a17b5@FreeBSD.org> In-Reply-To: <202007061710.066HA8TI006937@repo.freebsd.org> References: <202007061710.066HA8TI006937@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4B3Hyc68xJz4mjw X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[freebsd.org]; ASN(0.00)[asn:5432, ipnet:195.238.0.0/19, country:BE] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2020 16:08:25 -0000 On Mon, 6 Jul 2020 17:10:08 +0000 (UTC) Christian Weisgerber wrote: > Author: naddy > Date: Mon Jul 6 17:10:08 2020 > New Revision: 541352 > URL: https://svnweb.freebsd.org/changeset/ports/541352 > > Log: > Use the libtool script from devel/libtool. > The included libtool appears to be broken and loses the -lm dependency_lib, > so libvorbisenc and libvorbisfile did not get linked with -lm. > > PR: 247799 > > Modified: > head/audio/libvorbis/Makefile > > Modified: head/audio/libvorbis/Makefile > ============================================================================== > --- head/audio/libvorbis/Makefile Mon Jul 6 17:02:32 2020 (r541351) > +++ head/audio/libvorbis/Makefile Mon Jul 6 17:10:08 2020 (r541352) > @@ -3,6 +3,7 @@ > > PORTNAME= libvorbis > PORTVERSION= 1.3.7 > +PORTREVISION= 1 > PORTEPOCH= 3 > CATEGORIES= audio > MASTER_SITES= https://downloads.xiph.org/releases/vorbis/ \ > @@ -16,11 +17,13 @@ LICENSE_FILE= ${WRKSRC}/COPYING > > LIB_DEPENDS= libogg.so:audio/libogg > > -USES= libtool pathfix tar:xz > +# The included libtool is broken and loses the -lm dependency_lib. > +USES= libtool:build pathfix tar:xz > USE_LDCONFIG= yes > > GNU_CONFIGURE= yes > CONFIGURE_ARGS= --with-ogg=${LOCALBASE} > +MAKE_ARGS= LIBTOOL=${PREFIX}/bin/libtool > INSTALL_TARGET= install-strip > TEST_TARGET= check This is because the bundled libtool is the one from Debian, but it's also a bad practice to rely on the dependencies of a dependency so a better fix here would be to add -lm to libvorbisfile_la_LIBADD in WKRSRC/lib/Makefile.in. (It doesn't look like libvorbisenc needs libm.)