From owner-cvs-gnu Wed Aug 16 02:56:09 1995 Return-Path: cvs-gnu-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id CAA17568 for cvs-gnu-outgoing; Wed, 16 Aug 1995 02:56:09 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.FreeBSD.org (8.6.11/8.6.6) with ESMTP id CAA17554 ; Wed, 16 Aug 1995 02:55:37 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id CAA19210; Wed, 16 Aug 1995 02:54:58 -0700 From: "Rodney W. Grimes" Message-Id: <199508160954.CAA19210@gndrsh.aac.dev.com> Subject: Re: cvs commit: src/gnu/usr.bin/cvs/cvs import.c To: peter@freefall.FreeBSD.org (Peter Wemm) Date: Wed, 16 Aug 1995 02:54:58 -0700 (PDT) Cc: CVS-commiters@freefall.FreeBSD.org, cvs-gnu@freefall.FreeBSD.org In-Reply-To: <199508152038.NAA26516@freefall.FreeBSD.org> from "Peter Wemm" at Aug 15, 95 01:38:02 pm X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 1329 Sender: cvs-gnu-owner@FreeBSD.org Precedence: bulk > > peter 95/08/15 13:38:02 > > Modified: gnu/usr.bin/cvs/cvs import.c > Log: > This changes two things when importing an unreadable file: > 1: It stops invalid files being created in the cvs tree > 2: It stops the import from aborting without mailing a commit message.. > > The first is simple, it opens the file for reading before touching the > repository, and the second catches the pieces when it hits an unreadable > file rather than just aborting mid-way through, leaving the repository in > a bit mess. > > Reviewed by: rgrimes > I have combiled and install the /usr/bin/cvs binary _only_, the old version is saved incase we need to bail out for some unforseen reason: freefall:cvs {115} ls -lag /usr/bin/*cvs* -r-xr-xr-x 1 bin bin 151552 Aug 16 02:53 /usr/bin/cvs -r-xr-xr-x 1 bin bin 151552 Apr 14 13:07 /usr/bin/cvs.950414 -r-xr-xr-x 1 bin bin 139264 Jan 25 1995 /usr/bin/cvs.old -r-xr-xr-x 1 bin bin 8231 Apr 14 13:08 /usr/bin/cvsinit The version to restore would be cvs.950414. /usr/bin/cvs is the only file I touched on Freefall. No other binaries are effected by this patch, so no need to take risks. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Reliable computers for FreeBSD