From owner-p4-projects@FreeBSD.ORG  Sun Jul  3 20:53:29 2005
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 76F1416A420; Sun,  3 Jul 2005 20:53:29 +0000 (GMT)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5026316A41C
	for <perforce@freebsd.org>; Sun,  3 Jul 2005 20:53:29 +0000 (GMT)
	(envelope-from soc-victor@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 00C5843D48
	for <perforce@freebsd.org>; Sun,  3 Jul 2005 20:53:29 +0000 (GMT)
	(envelope-from soc-victor@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j63KrSqX022170
	for <perforce@freebsd.org>; Sun, 3 Jul 2005 20:53:28 GMT
	(envelope-from soc-victor@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j63KrSQI022167
	for perforce@freebsd.org; Sun, 3 Jul 2005 20:53:28 GMT
	(envelope-from soc-victor@freebsd.org)
Date: Sun, 3 Jul 2005 20:53:28 GMT
Message-Id: <200507032053.j63KrSQI022167@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	soc-victor@freebsd.org using -f
From: soc-victor <soc-victor@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 79503 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Jul 2005 20:53:30 -0000

http://perforce.freebsd.org/chv.cgi?CH=79503

Change 79503 by soc-victor@soc-victor_82.76.158.176 on 2005/07/03 20:53:03

	Minor fixes for the gensnmpdef tool to prevent some SIGSEGVs when no mibs specified on
	       the comamnd line.

Affected files ...

.. //depot/projects/soc2005/bsnmp/contrib/bsnmp/gensnmpdef/gensnmpdef.c#2 edit

Differences ...

==== //depot/projects/soc2005/bsnmp/contrib/bsnmp/gensnmpdef/gensnmpdef.c#2 (text+ko) ====

@@ -371,6 +371,11 @@
 	long u;
 	char *end;
 
+        if ( argc <= 1 ){
+		fprintf(stderr, usgtxt);
+		exit(0);
+	}
+	 
 	smiInit(NULL);
 
 	while ((opt = getopt(argc, argv, "c:h")) != -1)
@@ -396,6 +401,11 @@
 	argc -= optind;
 	argv += optind;
 
+        if( argc == 0 ){
+		fprintf(stderr,"No MIB specified\n");
+		exit(0);
+	}
+	
 	flags = smiGetFlags();
 	flags |= SMI_FLAG_ERRORS;
 	smiSetFlags(flags);
@@ -424,6 +434,10 @@
 				break;
 		}
 	}
-	level = close_node(last->oidlen - 1, level - 1);
+	if( last != NULL ){
+		level = close_node(last->oidlen - 1, level - 1);
+	}
+	
+	free(mods);	
 	return (0);
 }