From owner-freebsd-current Wed Aug 23 22: 5:17 2000 Delivered-To: freebsd-current@freebsd.org Received: from localhost (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id B431A37B422; Wed, 23 Aug 2000 22:05:14 -0700 (PDT) Date: Thu, 24 Aug 2000 01:05:13 -0400 (EDT) From: Brian Fundakowski Feldman X-Sender: green@green.dyndns.org To: Alfred Perlstein Cc: John Polstra , current@FreeBSD.ORG Subject: Re: panic: reducing sbsize: lost count, uid = 1001 In-Reply-To: <20000823145244.J4854@fw.wintelcom.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, 23 Aug 2000, Alfred Perlstein wrote: > * Alfred Perlstein [000823 14:29] wrote: > > > > I have a feeling that this is related to missing spl protection around > > the chgsbsize subsystem, this was probably an issue before I touched it > > but since I touched it last I'll have a look-see. > > > > Brian, does that makes sense? > [...] > > Does it make sense to wrap chgsbsize with spl so callers don't have > to worry about it? > Yeah, I say to go for it. I was /certain/ that these functions had the right spl()s before; if the patch fixes jdp's problem, I can't see a good reason not to change it, other than it would hide what may be quite problematic for other reasons even if not for that one... -- Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! / green@FreeBSD.org `------------------------------' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message