From owner-svn-src-head@freebsd.org  Sun Apr 23 13:07:39 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A6719D4BF7C;
 Sun, 23 Apr 2017 13:07:39 +0000 (UTC) (envelope-from jilles@stack.nl)
Received: from mailout.stack.nl (mailout05.stack.nl
 [IPv6:2001:610:1108:5010::202])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mailout.stack.nl",
 Issuer "CA Cert Signing Authority" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 757738E9;
 Sun, 23 Apr 2017 13:07:39 +0000 (UTC) (envelope-from jilles@stack.nl)
Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131])
 by mailout.stack.nl (Postfix) with ESMTP id 5290866;
 Sun, 23 Apr 2017 15:07:36 +0200 (CEST)
Received: by snail.stack.nl (Postfix, from userid 1677)
 id 407B528497; Sun, 23 Apr 2017 15:07:36 +0200 (CEST)
Date: Sun, 23 Apr 2017 15:07:36 +0200
From: Jilles Tjoelker <jilles@stack.nl>
To: Konstantin Belousov <kostikbel@gmail.com>
Cc: Ngie Cooper <ngie@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r317315 - head/lib/libc/gen
Message-ID: <20170423130736.GA53007@stack.nl>
References: <201704230317.v3N3HWtd040005@repo.freebsd.org>
 <20170423095345.GC57674@kib.kiev.ua>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170423095345.GC57674@kib.kiev.ua>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Apr 2017 13:07:39 -0000

On Sun, Apr 23, 2017 at 12:53:45PM +0300, Konstantin Belousov wrote:
> On Sun, Apr 23, 2017 at 03:17:32AM +0000, Ngie Cooper wrote:
> > Author: ngie
> > Date: Sun Apr 23 03:17:32 2017
> > New Revision: 317315
> > URL: https://svnweb.freebsd.org/changeset/base/317315

> > Log:
> >   Note that getpagesize(3) can return -1 on failure

> getpagesize() cannot fail.  This change only confuses the readers.

Although I agree that getpagesize() cannot fail and that it is
inappropriate to check for it, the code in lib/libc/gen/getpagesize.c
has a path where it returns -1 (if sysctl CTL_HW HW_PAGESIZE fails). It
probably makes more sense to abort() here to avoid confusing both humans
and static analyzers, and allow easier debugging if a bug causes it to
fail (instead of calculating bogus sizes from the -1 return value).

-- 
Jilles Tjoelker