Date: Wed, 22 Nov 2017 17:21:55 +0700 From: Alexey Dokuchaev <danfe@nsu.ru> To: x11@freebsd.org Subject: [patch] x11-servers/xorg-server: glamor: Fix dashed line rendering (from upstream) Message-ID: <20171122102155.GA97343@regency.nsu.ru>
next in thread | raw e-mail | index | archive | help
--FL5UXtIhxfXey3p5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Hi there,
May I commit the attached patch? It fixes displaying dashed and dotted
lines in 2D applications (e.g. bounding boxes around active widgets e.g.
buttons) which are drawn as solid lines without this patch. Found via
openSUSE's xorg-x11-server package.
./danfe
--FL5UXtIhxfXey3p5
Content-Type: text/plain; charset=koi8-r
Content-Disposition: attachment; filename="patch-glamor_glamor__dash.c"
Content-Transfer-Encoding: 8bit
From: Eric Anholt <eric@anholt.net>
Date: Wed Mar 15 17:51:46 2017 -0700
Subject: [PATCH]glamor: Fix dashed line rendering.
Patch-mainline: fe0b297420fc1de8a7fab28457d0864b3182e967
References: boo#1021803
Signed-off-by: Max Staudt <mstaudt@suse.de>
We were binding the screen pixmap as the dash and sampling its alpha,
which is usually just 1.0 (no dashing at all).
Please cherry-pick this to active stable branches.
Signed-off-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Keith Packard <keithp@keithp.com>
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
--- glamor/glamor_dash.c.orig 2016-07-18 19:08:16 UTC
+++ glamor/glamor_dash.c
@@ -146,7 +146,7 @@ glamor_dash_setup(DrawablePtr drawable, GCPtr gc)
goto bail;
dash_pixmap = glamor_get_dash_pixmap(gc);
- dash_priv = glamor_get_pixmap_private(pixmap);
+ dash_priv = glamor_get_pixmap_private(dash_pixmap);
if (!GLAMOR_PIXMAP_PRIV_HAS_FBO(dash_priv))
goto bail;
--FL5UXtIhxfXey3p5--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171122102155.GA97343>