From owner-freebsd-bugs@FreeBSD.ORG  Mon May 29 15:45:43 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DD36316AFF9;
	Mon, 29 May 2006 15:45:43 +0000 (UTC) (envelope-from ru@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DF09143DB3;
	Mon, 29 May 2006 15:45:34 +0000 (GMT) (envelope-from ru@FreeBSD.org)
Received: from freefall.freebsd.org (ru@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k4TFjXeE057764;
	Mon, 29 May 2006 15:45:33 GMT (envelope-from ru@freefall.freebsd.org)
Received: (from ru@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k4TFjX1R057760;
	Mon, 29 May 2006 15:45:33 GMT (envelope-from ru)
Date: Mon, 29 May 2006 15:45:33 GMT
From: Ruslan Ermilov <ru@FreeBSD.org>
Message-Id: <200605291545.k4TFjX1R057760@freefall.freebsd.org>
To: ru@FreeBSD.org, freebsd-bugs@FreeBSD.org, scottl@FreeBSD.org
Cc: 
Subject: Re: kern/98091: [ patch ] Makefile style of mfi kernel module broke
	the WARNS/NO_WERROR logic
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 May 2006 15:45:55 -0000

Synopsis: [ patch ] Makefile style of mfi kernel module broke the WARNS/NO_WERROR logic

Responsible-Changed-From-To: freebsd-bugs->scottl
Responsible-Changed-By: ru
Responsible-Changed-When: Mon May 29 15:40:27 UTC 2006
Responsible-Changed-Why: 
Scott, please fix it as per style.Makefile manpage:

     o   Do not use GCCisms (such as -g and -Wall) in CFLAGS.

     o   WARNS comes before CFLAGS, as it is basically a CFLAGS modifier.  It
         comes before CFLAGS rather than after CFLAGS so it does not get lost
         in a sea of CFLAGS statements as WARNS is an important thing.  The
         usage of WARNS is spelled ``WARNS?= '', so that it may be overridden
         on the command line or in make.conf(5).

http://www.freebsd.org/cgi/query-pr.cgi?pr=98091