From nobody Tue Jan 6 02:23:12 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dlZhj5w77z6Mx0B for ; Tue, 06 Jan 2026 02:23:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dlZhj5F94z3Frd for ; Tue, 06 Jan 2026 02:23:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767666197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rf87Tx7oDMKVKp3Q2aVgblQL72bDLHlJsJWdu1pKRO8=; b=tlKVEddvxCLAydcP0cKeW6eaKj3WnGVA1TmVCY/L+gdsDtTvmrAL4SkYuQttP9YnTHH8UH yIyw/NLA1k+j6pxiqIgvam90FbjxhE/ypJvEWLxkswXk3Dkzsq89fL3gAlIvzXMgY9kCTn sNEAest7CtbtVQS9tjwhKV8YtNk3fxEZrpfmbukTCIkZ61SEsxGHIxI1ejD+dKOv+0+Per OjAwA4J9jT0PF1rOSpnEUUjQ97UXPEqgY0+2BBo7ffurdwetr32E2zn7S93Ec2nzvJT200 j490khdz85ra51va4gPaUs1cx3LJtPDVjrGdk5bLy3MRRCYt3jxfRUHd9GHM3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767666197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rf87Tx7oDMKVKp3Q2aVgblQL72bDLHlJsJWdu1pKRO8=; b=sNfA4MYbCj9c+Ae//aaHRKF8WJvQ52IgMiBWokAt5FBkObeCjGFZE3lArTHXyNZqkttSBg BG9KotiEapEsEIdN3ef2IR6VXz6E79xy2jXIP4oxS0q8glbOZYZVqvyNzhQiIEXxmgiQ1K Uo+zjqkYYrdfc74N8dd1i7dQftpecu1/+bq1DLPMtdYHJPkz29qH3Jxa99kBkIPBD+h+K2 IClnvQchoLPRv19tbzS7AYM2o5Bk3bDz0JVY4yvpAMDHv6c1yAdTB55vftzoLpL8EYVgEP +duP/ZtvThuuCn6caxEyP4H2oMS3akZi6+qXkrDA0WbPCFhHh6Sxe66IpPk+7g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1767666197; a=rsa-sha256; cv=none; b=EuEkgTLzgZeMUzO3ewVQJgt4Nd8GcNPgYYbfybw6Jklv90yjEzDlH3dPNp5glHmINUQJb9 F3RPR23wja5ODb1j+52hNVjEyBEIBQsdjKOwshlB3rE8i/u5N+Z6phl1qHRN9x0tnwSC0Z Klz43o/GbwUngKEJXz3xnnYlKzt+Ksjps1kBpJy3ELUNhmfST9PDOJaOPOPgX5fzFk2+RR i1uWnY14lud4giRlpMCyhNgBISMm12SaYoPNo2dzdomVSs2tdNsqE/CuQq1h2SXJCFXFbi c4sQ/zMyvmZr/AAbvypMSFIDeUmAcDHPNz5GMdbn0vOAQW0nGCLHYOVlpjZ+QA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dlZhj4TQNznRc for ; Tue, 06 Jan 2026 02:23:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 44db0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 06 Jan 2026 02:23:12 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ahmad Khalifa Subject: git: 9b2478f60bfd - main - ng_tty: avoid the sign extention of char List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9b2478f60bfda663c84b48e272a2293159e1b0a0 Auto-Submitted: auto-generated Date: Tue, 06 Jan 2026 02:23:12 +0000 Message-Id: <695c7210.44db0.1fed2d7b@gitrepo.freebsd.org> The branch main has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=9b2478f60bfda663c84b48e272a2293159e1b0a0 commit 9b2478f60bfda663c84b48e272a2293159e1b0a0 Author: Ahmad Khalifa AuthorDate: 2026-01-06 02:07:29 +0000 Commit: Ahmad Khalifa CommitDate: 2026-01-06 02:10:11 +0000 ng_tty: avoid the sign extention of char When c is compared to sc->hotchar, both undergo integer promotion, which can lead to c being sign extended. Fix this by casting c to an unsigned char. Reviewed by: kevans MFC after: 5 days Differential Revision: https://reviews.freebsd.org/D54544 --- sys/netgraph/ng_tty.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/netgraph/ng_tty.c b/sys/netgraph/ng_tty.c index 0e3230a66f66..200a72336110 100644 --- a/sys/netgraph/ng_tty.c +++ b/sys/netgraph/ng_tty.c @@ -489,7 +489,8 @@ ngt_rint(struct tty *tp, char c, int flags) m->m_pkthdr.len++; /* Ship off mbuf if it's time */ - if (sc->hotchar == -1 || c == sc->hotchar || m->m_len >= MHLEN) { + if (sc->hotchar == -1 || (u_char)c == sc->hotchar || + m->m_len >= MHLEN) { sc->m = NULL; NG_SEND_DATA_ONLY(error, sc->hook, m); /* Will queue */ }