From owner-svn-ports-all@freebsd.org Sun Apr 16 20:51:32 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6EE7AD41A41; Sun, 16 Apr 2017 20:51:32 +0000 (UTC) (envelope-from db@db.net) Received: from diana.db.net (diana.db.net [66.113.102.10]) by mx1.freebsd.org (Postfix) with ESMTP id 4FC401519; Sun, 16 Apr 2017 20:51:31 +0000 (UTC) (envelope-from db@db.net) Received: from night.db.net (localhost [127.0.0.1]) by diana.db.net (Postfix) with ESMTP id 20B882AA360; Sun, 16 Apr 2017 14:50:16 -0600 (MDT) Received: by night.db.net (Postfix, from userid 1000) id D208D39873; Sun, 16 Apr 2017 16:51:29 -0400 (EDT) Date: Sun, 16 Apr 2017 16:51:29 -0400 From: Diane Bruce To: Diane Bruce Cc: Kyle Evans , Alexey Dokuchaev , Diane Bruce , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r436814 - in head/comms: . direwolf direwolf/files Message-ID: <20170416205129.GA793@night.db.net> References: <201703241401.v2OE1nwY023666@repo.freebsd.org> <20170325014740.GC54562@FreeBSD.org> <20170325032842.GA90279@night.db.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170325032842.GA90279@night.db.net> User-Agent: Mutt/1.8.0 (2017-02-23) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Apr 2017 20:51:32 -0000 Looks like this was my mistake. Kyle I thought you were going to do a new PR with an updated upstream with the universal Makefile. Was your fix approved upstream? They have at least one update after this commit. - Diane On Fri, Mar 24, 2017 at 11:28:42PM -0400, Diane Bruce wrote: > On Fri, Mar 24, 2017 at 09:28:26PM -0500, Kyle Evans wrote: > > On Fri, Mar 24, 2017 at 8:47 PM, Alexey Dokuchaev wrote: > > > It was not explained why the FreeBSD version of Makefile is needed at all. > > > What's wrong with original version? Most of its contents are not related > > > to FreeBSD in any way. > > > > The project Makefile does a basic OS check then includes > > Makefile.{linux,macosx,win}. The linux/macosx makefiles contain enough > > platform specific things that we saw fit to write a FreeBSD version. > > We're doing some work with upstream to get this integrated into > > Direwolf in a manner that's more maintainable by all. > > It looked as if upstream simply preferred a separate platform > specific Makefile much as other projects have done in the past; > But after requesting a pull request upstream expressed a preference > for a single Makefile and work was started on this. > > > > > I'm attaching a patch that should address your concerns, with > > PORTREVISION bumped due to the dw-start.sh change -- /usr/local was > > I note that upstream already have a change we can pull in with > next iteration hence a PORTREVISION will not be necessary. > > > > > Thanks, > > > > Kyle Evans > > -- > - db@FreeBSD.org db@db.net http://www.db.net/~db > -- - db@FreeBSD.org db@db.net http://www.db.net/~db