From owner-freebsd-current@FreeBSD.ORG  Wed Feb 22 14:18:57 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3643716A420;
	Wed, 22 Feb 2006 14:18:57 +0000 (GMT)
	(envelope-from xdivac02@stud.fit.vutbr.cz)
Received: from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.10.14])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 88ABF43D4C;
	Wed, 22 Feb 2006 14:18:55 +0000 (GMT)
	(envelope-from xdivac02@stud.fit.vutbr.cz)
Received: from eva.fit.vutbr.cz (localhost [127.0.0.1])
	by eva.fit.vutbr.cz (envelope-from xdivac02@eva.fit.vutbr.cz)
	(8.13.4/8.13.3) with ESMTP id k1MEIpHr044058
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO);
	Wed, 22 Feb 2006 15:18:52 +0100 (CET)
Received: (from xdivac02@localhost)
	by eva.fit.vutbr.cz (8.13.4/8.13.3/Submit) id k1MEIpfj044057;
	Wed, 22 Feb 2006 15:18:51 +0100 (CET)
Date: Wed, 22 Feb 2006 15:18:51 +0100
From: Divacky Roman <xdivac02@stud.fit.vutbr.cz>
To: Doug Barton <dougb@freebsd.org>
Message-ID: <20060222141851.GA43749@stud.fit.vutbr.cz>
References: <20060217181842.GA21033@odin.ac.hmc.edu>
	<43F65A70.7080608@FreeBSD.org>
	<20060217234118.GA22643@odin.ac.hmc.edu>
	<43F67121.5080809@FreeBSD.org> <43F682F2.1020804@FreeBSD.org>
	<43F68611.7080602@FreeBSD.org>
	<20060219110732.GA12550@stud.fit.vutbr.cz>
	<43F8ABC8.30005@FreeBSD.org> <20060221180440.GB2996@galgenberg.net>
	<43FBC1E4.7020204@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <43FBC1E4.7020204@FreeBSD.org>
User-Agent: Mutt/1.4.2i
X-Scanned-By: MIMEDefang 2.49 on 147.229.10.14
Cc: freebsd-current@freebsd.org
Subject: Re: Bad code in rcorder(8) (Was: Re: New RCorder: abi loaded too
	late)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Feb 2006 14:18:57 -0000

On Tue, Feb 21, 2006 at 05:44:04PM -0800, Doug Barton wrote:
> Ulrich Spoerlein wrote:
> 
> >> Divacky Roman wrote:
> >>> I tried running rcorder under valgrind and it showed me massive
> >>> leaks/double-frees etc. unfortunately I am not able to run valgrind on recent
> >>> 7-current (when I start it it just creates 2.8G coredump)
> 
> > Looks fine to me ...
> 
> I think the trick is to repeat your test with some bad stuff in the scripts.
> So, create some circular dependencies, and some other impossible conditions,
> then repeat the test.
 
yes... I tried running valgrind on circular dependancies... that showed some
mem leaks.... see http://www.freebsd.org/cgi/query-pr.cgi?pr=91789, I got that
leaks when investigating this PR (iirc)
 
> Also, Divacky posted a PR with a start to cleaning up the code, might be
> worth some before and after on that.
> http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/93630

my patch doesnt solve any such problems. its just a little cleanup I did when
looking at the code.