From owner-svn-src-all@FreeBSD.ORG Sun Oct 28 20:07:03 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B9ED64E2; Sun, 28 Oct 2012 20:07:03 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117]) by mx1.freebsd.org (Postfix) with ESMTP id 3305E8FC08; Sun, 28 Oct 2012 20:07:02 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id q9SK71Nw024342; Mon, 29 Oct 2012 00:07:01 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id q9SK71Js024341; Mon, 29 Oct 2012 00:07:01 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 29 Oct 2012 00:07:00 +0400 From: Gleb Smirnoff To: Andre Oppermann Subject: Re: svn commit: r242254 - head/sys/netinet Message-ID: <20121028200700.GL70741@FreeBSD.org> References: <201210281807.q9SI7Yxa069395@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <201210281807.q9SI7Yxa069395@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Oct 2012 20:07:03 -0000 On Sun, Oct 28, 2012 at 06:07:34PM +0000, Andre Oppermann wrote: A> @@ -296,8 +297,8 @@ syncache_destroy(void) A> mtx_destroy(&sch->sch_mtx); A> } A> A> - KASSERT(V_tcp_syncache.cache_count == 0, ("%s: cache_count %d not 0", A> - __func__, V_tcp_syncache.cache_count)); A> + KASSERT(uma_zone_get_cur(V_tcp_syncache.zone) == 0, A> + ("%s: cache_count not 0", __func__)); A> A> /* Free the allocated global resources. */ A> uma_zdestroy(V_tcp_syncache.zone); btw, keg_dtor() which is called in uma_zdestroy() printfs a warning (even on non-invariant kernel) if keg had items in it. So leak won't be unnoticed. -- Totus tuus, Glebius.