From owner-svn-ports-all@freebsd.org Sun Jun 2 20:39:34 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2E55715BF393; Sun, 2 Jun 2019 20:39:34 +0000 (UTC) (envelope-from benny.goemans@gmail.com) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7307B77A6A; Sun, 2 Jun 2019 20:39:33 +0000 (UTC) (envelope-from benny.goemans@gmail.com) Received: by mail-wr1-x444.google.com with SMTP id c2so9939747wrm.8; Sun, 02 Jun 2019 13:39:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=4Gi8UvWLu77tKd3IgY7zq8FlmCZLJUL8QT38C09HqhA=; b=rF7lPwdWRVCq0MsJXYqW3hWQXZbCn0gnqAiGYeUuqpWns2DOghYEkXVyRC5Ifl+ewX nkwiUiIwxObZw28buEeMzEgJKY9o1Z6zUq7vP5X13mJrQD6yt/EbeBUorBLGif+zu6W0 rAB8prBBjdxGfNw1BObBbA0y+rIJJDpxhJQrxoMkFTdNdey0D0H8q9TujF3gBh809D8R rZ3ivzEh8Rv4i8Lh/+wXtWqp2JvO3sMeEYfAJ970GQSJv18tVSkyeUQVH/78xl1XEeac 1SLkACrfsR68/4VbBnwPQvClf4Ojm+SF2xl/IK57+BIAVkHPEy9Ij1ncf/n9H2Tm7jTT saEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=4Gi8UvWLu77tKd3IgY7zq8FlmCZLJUL8QT38C09HqhA=; b=mVQ3GlKROfr7A2I/BIcRV6FSRlqmmeRBcO4/+oK3NUGK3u3MXUaR+eqArLC5S0gbie WwRWjA01y+kd/8v0peB+O3ligMdsr8TMZa2b6xEFSWkXV5wxSzI72DROXZgVWN74tc0F vaTpQXhhmYkbAGoqxaxQ62rbXTyBh1GvU9eqTZGF1CiBRkKLMRcgtyOuWMY9C7RwMN4z Mr2Pqfyji0ZZfP6OKpn/Y74JsUH9JDeI6zFU7UoPDEQa8M565/GbS5v7DETtnkY2kA2x CObzjFU6K/useE7q5sNFh/QP54e8nsiKSkQJu0Q4rlLfLQZjNnT4C7Oj1NA40OZH729X tL8g== X-Gm-Message-State: APjAAAVnD1gf0fmBIZDtTuHwtJxdpyl+8NSh+6HmVjB3pKTLH84Hgo4d mYISgvQ0T5C2yzxOaJLFwSFHWgek X-Google-Smtp-Source: APXvYqyWLLI4GCzw38alHHEGxNqv9DWA21wequtTDkKoI6n6bPIvh2SIK7jtewGfoOsfQPfhCN/I8A== X-Received: by 2002:adf:f542:: with SMTP id j2mr68594wrp.16.1559507969907; Sun, 02 Jun 2019 13:39:29 -0700 (PDT) Received: from [192.168.0.29] (d54C08FBD.access.telenet.be. [84.192.143.189]) by smtp.googlemail.com with ESMTPSA id o11sm6634682wrx.4.2019.06.02.13.39.27 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Sun, 02 Jun 2019 13:39:28 -0700 (PDT) Subject: Re: svn commit: r502742 - in head/games: . devilutionX devilutionX/files To: Gerald Pfeifer , Steve Wills , Tobias Kortkamp Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201905261834.x4QIYhE7073602@repo.freebsd.org> From: Benny Goemans Message-ID: <3802270e-645c-a446-fc6a-bdf70c81fd22@gmail.com> Date: Sun, 2 Jun 2019 22:39:26 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Rspamd-Queue-Id: 7307B77A6A X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.993,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Jun 2019 20:39:34 -0000 On 2019-06-02 21:38, Gerald Pfeifer wrote: > On Sun, 26 May 2019, Steve Wills wrote: >> Author: swills >> Date: Sun May 26 18:34:42 2019 >> New Revision: 502742 >> URL: https://svnweb.freebsd.org/changeset/ports/502742 >> >> Log: >> games/devilutionX: create port >> >> Open-Source implementation of the Diablo(TM) game engine for X. This port >> requires a file from the original game to work. >> >> WWW: https://github.com/diasurgical/devilutionX > I was going to comment on this after noticing the following > combination... > >> +USES= cmake compiler:c++14-lang dos2unix sdl >> +USE_GCC= yes > ...but it appears Tobias bet me to it with > > r502770 | tobik | 2019-05-27 06:32:24 +0000 (Mo., 27 Mai 2019) > > games/devilutionX: Remove USES=compiler:c++14-lang > > It does not make any sense when also setting USE_GCC=yes. > > Now the question is: does it really have to be GCC (and if so, why)? > > We generally prefer not to depend on a specific compiler make (or > version), and this says the guy who maintains the lang/gcc* ports. ;-) > > Gerald The upstream committer(s) have been looking into compilation on Clang, but hadn't been able to do that on FreeBSD (just yet). They did however manage to do it on MacOS. Should I find some more time to try and tackle this myself, I'll put out another diff to remove GCC use. I'd prefer to use Clang as well. I have however tried this a few times and haven't been able to fix it myself, but I don't know much about GCC and Clang differences. So it'll probably take some time. Regards, Benny