From owner-svn-src-all@FreeBSD.ORG Sat May 23 07:16:46 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EB4591065670; Sat, 23 May 2009 07:16:46 +0000 (UTC) (envelope-from dfr@rabson.org) Received: from itchy.rabson.org (router.rabson.org [80.177.232.241]) by mx1.freebsd.org (Postfix) with ESMTP id 69C948FC0C; Sat, 23 May 2009 07:16:46 +0000 (UTC) (envelope-from dfr@rabson.org) Received: from [IPv6:2001:470:909f:1:225:ff:feed:9426] (unknown [IPv6:2001:470:909f:1:225:ff:feed:9426]) by itchy.rabson.org (Postfix) with ESMTP id DB8475DBA; Sat, 23 May 2009 08:17:29 +0100 (BST) Message-Id: <49964BF0-5B45-46C4-9711-9A30F966A4B8@rabson.org> From: Doug Rabson To: d@delphij.net In-Reply-To: <4A1734DC.6080203@delphij.net> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Date: Sat, 23 May 2009 08:16:15 +0100 References: <200905161048.n4GAmKRh057122@svn.freebsd.org> <4A1734DC.6080203@delphij.net> X-Mailer: Apple Mail (2.935.3) Cc: svn-src-head@FreeBSD.ORG, Doug Rabson , src-committers@FreeBSD.ORG, svn-src-all@FreeBSD.ORG Subject: Re: svn commit: r192194 - in head/sys: boot/i386/zfsboot boot/zfs cddl/boot/zfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 May 2009 07:16:47 -0000 Thanks for the report - I'll put together a repro scenario and fix it as soon as possible. On 23 May 2009, at 00:27, Xin LI wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi, Doug, > > Doug Rabson wrote: >> Author: dfr >> Date: Sat May 16 10:48:20 2009 >> New Revision: 192194 >> URL: http://svn.freebsd.org/changeset/base/192194 >> >> Log: >> Add support for booting from raidz1 and raidz2 pools. >> >> Modified: >> head/sys/boot/i386/zfsboot/zfsboot.c >> head/sys/boot/zfs/zfsimpl.c >> head/sys/cddl/boot/zfs/README >> head/sys/cddl/boot/zfs/zfsimpl.h >> head/sys/cddl/boot/zfs/zfssubr.c > > I think this commit has broken booting from mirrored zpool when raidz2 > pool is exist. In my setup it was 4 disks: > > [lixin@stortank] /usr/src/sys> gpart show > => 34 1953525101 da0 GPT (932G) > 34 128 1 freebsd-boot (64K) > 162 2097152 2 freebsd-zfs (1.0G) > 2097314 4194304 3 freebsd-swap (2.0G) > 6291618 1947233517 4 freebsd-zfs (929G) > > => 34 1953525101 da1 GPT (932G) > 34 128 1 freebsd-boot (64K) > 162 2097152 2 freebsd-zfs (1.0G) > 2097314 4194304 3 freebsd-swap (2.0G) > 6291618 1947233517 4 freebsd-zfs (929G) > > => 34 1953525101 da2 GPT (932G) > 34 128 1 freebsd-boot (64K) > 162 2097152 2 freebsd-zfs (1.0G) > 2097314 4194304 3 freebsd-swap (2.0G) > 6291618 1947233517 4 freebsd-zfs (929G) > > => 34 1953525101 da3 GPT (932G) > 34 128 1 freebsd-boot (64K) > 162 2097152 2 freebsd-zfs (1.0G) > 2097314 4194304 3 freebsd-swap (2.0G) > 6291618 1947233517 4 freebsd-zfs (929G) > > Where da?p2 are in a mirrored zpool and da?p4 are in a raid-z2 pool: > > pool: startpoint > state: ONLINE > scrub: none requested > config: > > NAME STATE READ WRITE CKSUM > startpoint ONLINE 0 0 0 > mirror ONLINE 0 0 0 > da0p2 ONLINE 0 0 0 > da1p2 ONLINE 0 0 0 > da2p2 ONLINE 0 0 0 > da3p2 ONLINE 0 0 0 > > errors: No known data errors > > pool: stortank > state: ONLINE > scrub: none requested > config: > > NAME STATE READ WRITE CKSUM > stortank ONLINE 0 0 0 > raidz2 ONLINE 0 0 0 > label/disk0 ONLINE 0 0 0 > label/disk1 ONLINE 0 0 0 > label/disk2 ONLINE 0 0 0 > label/disk3 ONLINE 0 0 0 > > It looks like that the gptzfsboot can recognize the mirrored > 'startpoint' pool and load loader correctly (when I specify > loader.old, > it worked just fine) but the loader can not. I've tried to > > Cheers, > - -- > Xin LI http://www.delphij.net/ > FreeBSD - The Power to Serve! > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.11 (FreeBSD) > > iEYEARECAAYFAkoXNNsACgkQi+vbBBjt66BrYACguD5mHU4PyUUINe1eJf69G6Vv > HL4An1I0fwokIF/Sc4fKCAgz3xH5Gwzq > =YgBz > -----END PGP SIGNATURE-----