From owner-freebsd-current Wed Apr 28 11:33:40 1999 Delivered-To: freebsd-current@freebsd.org Received: from herring.nlsystems.com (nlsys.demon.co.uk [158.152.125.33]) by hub.freebsd.org (Postfix) with ESMTP id 663F015782 for ; Wed, 28 Apr 1999 11:33:17 -0700 (PDT) (envelope-from dfr@nlsystems.com) Received: from localhost (dfr@localhost) by herring.nlsystems.com (8.9.3/8.8.8) with ESMTP id TAA41250; Wed, 28 Apr 1999 19:33:18 +0100 (BST) (envelope-from dfr@nlsystems.com) Date: Wed, 28 Apr 1999 19:33:18 +0100 (BST) From: Doug Rabson To: Nate Williams Cc: Warner Losh , Alex Zepeda , Peter Mutsaers , freebsd-current@FreeBSD.ORG Subject: Re: suspend mode broken since one week ago In-Reply-To: <199904281414.IAA08646@mt.sri.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, 28 Apr 1999, Nate Williams wrote: > > > : Someone submitted a patch that checked to see if the BIOS returned a > > > : value > 64M, and if so to 'accept' it's value for the memory, since it's > > > : more likely to be correct. I'd like to apply it to -current, but I'm > > > : not sure of the political ramifications.... > > > > > > I think that it would be OK to do this, especially if you were able to > > > sanity check the numbers against something else... If it isn't > > > possible to do a sanity check, then I'd still be tempted to commit it, > > > making it an option if it causes problems for a significant number (> > > > 1%) of people. > > > > My patch looks like this: > > > > Index: machdep.c > > =================================================================== > > RCS file: /home/ncvs/src/sys/i386/i386/machdep.c,v > > retrieving revision 1.330 > > diff -u -r1.330 machdep.c > > --- machdep.c 1999/04/19 14:14:12 1.330 > > +++ machdep.c 1999/04/26 13:20:30 > > @@ -1403,8 +1403,9 @@ > > } > > } > > if (bootinfo.bi_extmem != biosextmem) > > - printf("BIOS extmem (%uK) != RTC extmem (%uK)\n", > > + printf("BIOS extmem (%uK) != RTC extmem (%uK), setting to BIOS value\n", > > bootinfo.bi_extmem, biosextmem); > > + biosextmem = bootinfo.bi_extmem; > > } > > > > #ifdef SMP > > > > I don't think this is complete, because I think (don't know) that many > older BIOS's only reported up to 64M of memory, so if you had more than > 64M in the box it didn't report it. > > However, I can't verify this since I don't have any machines with > 64M > of memory. I wasn't intending to commit the patch since I don't really understand all the compatibility problems. I just wanted to be able to read the ACPI tables on my laptop... -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 442 9037 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message