From owner-freebsd-ports@FreeBSD.ORG Wed Apr 19 17:51:02 2006 Return-Path: X-Original-To: freebsd-ports@freebsd.org Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 469D216A42A for ; Wed, 19 Apr 2006 17:51:02 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id A931143DEC for ; Wed, 19 Apr 2006 17:50:39 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id 9225F1A4DA7; Wed, 19 Apr 2006 10:50:39 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 372E554E76; Wed, 19 Apr 2006 13:50:37 -0400 (EDT) Date: Wed, 19 Apr 2006 13:50:36 -0400 From: Kris Kennaway To: Larry Rosenman Message-ID: <20060419175036.GA71370@xor.obsecurity.org> References: <20060419173254.GB70979@xor.obsecurity.org> <023e01c663d7$9a10d270$0202fea9@aus.pervasive.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline In-Reply-To: <023e01c663d7$9a10d270$0202fea9@aus.pervasive.com> User-Agent: Mutt/1.4.2.1i Cc: freebsd-ports@freebsd.org, 'Kris Kennaway' Subject: Re: -fPIC for a port that is just a library on amd64? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 17:51:04 -0000 --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 19, 2006 at 12:35:07PM -0500, Larry Rosenman wrote: > Kris Kennaway wrote: > > On Wed, Apr 19, 2006 at 09:52:38AM -0500, Larry Rosenman wrote: > >> What's the best way to get a port to add -fPIC to the compile for a > >> port that generates just an archive library (textproc/libxdiff)? > >>=20 > >> I was able to force the issue with CFLAGS=3D-fPIC make;CFLAGS=3D-fpic > >> make install, but it would be nice if the port could do it > >> automagically.=20 > >=20 > > It would be nice if the software was already correct so it happened > > automatically :-) > >=20 > >> The issue is that the pecl-xdiff extension uses this library and > >> wants to be a shared object. > >=20 > > If it's only compiling a shared library object (not static object or > > other binaries), then adding CFLAGS+=3D -fPIC to the port makefile is > > acceptable. Better, add it to the software makefile and contribute > > your patch back upstream. > >=20 > > Kris >=20 > It's just compiling a static object (a libxdiff.a). >=20 > I just submitted a patch to the port that if ${MACHINE} =3D=3D amd64=20 > I do the CFLAGS+=3D -fPIC > but I'm not sure that's acceptable to you folks on portmgr. How is this object used? Is it really supposed to be static? Kris --AhhlLboLdkugWU4S Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFERnhsWry0BWjoQKURAldjAKDxph1RHwBPtbZ77CgqKGIPwTo2pgCgrACJ mWnD6/cQwww7plzyOs/ITcw= =FuWt -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S--