From owner-cvs-src@FreeBSD.ORG Wed Dec 7 01:38:29 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C163A16A41F; Wed, 7 Dec 2005 01:38:28 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7ACF643D5A; Wed, 7 Dec 2005 01:38:28 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id jB71cS5L096892; Wed, 7 Dec 2005 01:38:28 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id jB71cSjG096891; Wed, 7 Dec 2005 01:38:28 GMT (envelope-from pjd) Message-Id: <200512070138.jB71cSjG096891@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Wed, 7 Dec 2005 01:38:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/geom/class/concat geom_concat.c src/sbin/geom/class/eli geom_eli.c src/sbin/geom/class/label geom_label.c src/sbin/geom/class/mirror geom_mirror.c src/sbin/geom/class/raid3 geom_raid3.c src/sbin/geom/class/shsec geom_shsec.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2005 01:38:29 -0000 pjd 2005-12-07 01:38:28 UTC FreeBSD src repository Modified files: sbin/geom/class/concat geom_concat.c sbin/geom/class/eli geom_eli.c sbin/geom/class/label geom_label.c sbin/geom/class/mirror geom_mirror.c sbin/geom/class/raid3 geom_raid3.c sbin/geom/class/shsec geom_shsec.c sbin/geom/class/stripe geom_stripe.c sbin/geom/core geom.c sbin/geom/misc subr.c subr.h Log: - The geom(8) utility only uses three types of arguments: string (char *), value (intmax_t) and boolean (int). Based on that provide three functions: - gctl_get_ascii() - gctl_get_int() - gctl_get_intmax() - Hide gctl_get_param() function, as it is only used internally in subr.c. - Allow to provide argument name as (fmt, ...). - Assert geom(8) bugs (missing argument is a geom(8) bug). - Clean-up and simplify the code by using new functions and assumtions (no more checking for missing argument). Tested by: regression tests Revision Changes Path 1.9 +24 -57 src/sbin/geom/class/concat/geom_concat.c 1.5 +85 -236 src/sbin/geom/class/eli/geom_eli.c 1.7 +16 -43 src/sbin/geom/class/label/geom_label.c 1.12 +36 -92 src/sbin/geom/class/mirror/geom_mirror.c 1.14 +35 -81 src/sbin/geom/class/raid3/geom_raid3.c 1.6 +24 -56 src/sbin/geom/class/shsec/geom_shsec.c 1.12 +31 -67 src/sbin/geom/class/stripe/geom_stripe.c 1.24 +20 -53 src/sbin/geom/core/geom.c 1.5 +55 -45 src/sbin/geom/misc/subr.c 1.5 +5 -3 src/sbin/geom/misc/subr.h