From owner-svn-ports-head@FreeBSD.ORG  Fri Aug 29 16:31:15 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E5674CBB;
 Fri, 29 Aug 2014 16:31:15 +0000 (UTC)
Received: from mail-qg0-x233.google.com (mail-qg0-x233.google.com
 [IPv6:2607:f8b0:400d:c04::233])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 7530613A5;
 Fri, 29 Aug 2014 16:31:15 +0000 (UTC)
Received: by mail-qg0-f51.google.com with SMTP id i50so2443297qgf.38
 for <multiple recipients>; Fri, 29 Aug 2014 09:31:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=au5gedydID2rmxBQgOq4JueEQEdPh8tBYgxWYq73o8I=;
 b=hMVifu8eVjARpEU3O6cHuvTzl9ptmOByKY1u0mJvERmkBv433v5ZMLvkzE9SNc6RJ8
 GQ0SMikcXl7YWZyRTpX1IJZB65iv46jv/riuetWaD6xd0F+vFPL2+TWHX/A/nCOYWgHZ
 H1MU7bkWNVQ2L0Pq6jVzktDF5bauJAQD19mnHA9Lsx+gP7pIScnCNPRPQVZjGCC+SwGE
 OskpcddJIGZJ3IbD4F2RcO9qdc+SmpguFw2VY2oAl2jnFMVMmSXO8A01i40twQ0y7SCE
 RHP931Z4O0WxpOCKG7a8qhYdun0D/7JyyQZdM0BIxDjrA/4RMtaEf/ImVlDjRAyFmtMu
 c+mg==
MIME-Version: 1.0
X-Received: by 10.140.91.229 with SMTP id z92mr18609764qgd.8.1409329874485;
 Fri, 29 Aug 2014 09:31:14 -0700 (PDT)
Sender: william88@gmail.com
Received: by 10.140.83.134 with HTTP; Fri, 29 Aug 2014 09:31:14 -0700 (PDT)
In-Reply-To: <201408291613.s7TGD21p034102@svn.freebsd.org>
References: <201408291613.s7TGD21p034102@svn.freebsd.org>
Date: Fri, 29 Aug 2014 13:31:14 -0300
X-Google-Sender-Auth: ye8_MAXPngiuXqeDY5-MRRgkRRw
Message-ID: <CAHtVNLMeNSC_TSc-MWC92Y_rm_wn3wCzQKaFOhDx=JDFa_hbEg@mail.gmail.com>
Subject: Re: svn commit: r366524 - head/devel/libavl
From: William Grzybowski <wg@freebsd.org>
To: Antoine Brodin <antoine@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 ports-committers <ports-committers@freebsd.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Aug 2014 16:31:16 -0000

On Fri, Aug 29, 2014 at 1:13 PM, Antoine Brodin <antoine@freebsd.org> wrote:
> Author: antoine
> Date: Fri Aug 29 16:13:01 2014
> New Revision: 366524
> URL: http://svnweb.freebsd.org/changeset/ports/366524
> QAT: https://qat.redports.org/buildarchive/r366524/
>
> Log:
>   Allow staging as a regular user
>
> Modified:
>   head/devel/libavl/Makefile
>
> Modified: head/devel/libavl/Makefile
> ==============================================================================
> --- head/devel/libavl/Makefile  Fri Aug 29 15:56:59 2014        (r366523)
> +++ head/devel/libavl/Makefile  Fri Aug 29 16:13:01 2014        (r366524)
> @@ -15,4 +15,7 @@ GNU_CONFIGURE=        yes
>
>  INFO=          avl
>
> +post-patch:
> +       ${REINPLACE_CMD} -e '/echo.*RANLIB/,+1d' ${WRKSRC}/Makefile.in
> +
>  .include <bsd.port.mk>

Maybe its worth putting a comment in the code about it?
Its not direct obvious, at least for me, that a sed in a line
containing RANLIB would allow a regular user to stage the port.

Maybe its just me being paranoid or w/e, if so disregard :)


Thanks,



-- 
William Grzybowski / wg
FreeBSD Ports Committer