From owner-cvs-all@FreeBSD.ORG  Mon Jul  4 07:51:22 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3A3F716A41C;
	Mon,  4 Jul 2005 07:51:22 +0000 (GMT)
	(envelope-from thompsa@freebsd.org)
Received: from heff.fud.org.nz (60-234-149-201.bitstream.orcon.net.nz
	[60.234.149.201])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D051343D48;
	Mon,  4 Jul 2005 07:51:21 +0000 (GMT)
	(envelope-from thompsa@freebsd.org)
Received: by heff.fud.org.nz (Postfix, from userid 1001)
	id 0F7C51CCD4; Mon,  4 Jul 2005 19:51:20 +1200 (NZST)
Date: Mon, 4 Jul 2005 19:51:19 +1200
From: Andrew Thompson <thompsa@freebsd.org>
To: Mike Silbersack <silby@silby.com>
Message-ID: <20050704075119.GA11500@heff.fud.org.nz>
References: <200507031824.j63IO3Bs009536@repoman.freebsd.org>
	<20050703184013.U21939@odysseus.silby.com>
	<20050703235733.GA8138@heff.fud.org.nz>
	<20050704005749.D21939@odysseus.silby.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050704005749.D21939@odysseus.silby.com>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/net bridge.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jul 2005 07:51:22 -0000

On Mon, Jul 04, 2005 at 12:59:10AM -0500, Mike Silbersack wrote:
> 
> On Mon, 4 Jul 2005, Andrew Thompson wrote:
> 
> >Both bridges tap their packets off near the end of ether_input(). Since
> >we only need to check alignment when using pfil(9) and each bridge has
> >its own knobs to control filtering, it seems best to leave it where it
> >is at the moment.
> 
> Well, where it was at was the network drivers.  Since we know that em is 
> the (only?) violator, you're arguing for the backout of your patch when 
> you say "leave it where it is."
> 
> The other protocol stacks need aligned headers too, that's why I'm curious 
> as to the bridge-specificness of this patch.

Because I have only made a handful of commits so far and they were all
to if_bridge, so im a little narrow minded at the moment ;-)

If there is a better way to do this im all for it.


Andrew