From owner-svn-ports-all@freebsd.org Sat Jan 6 18:25:38 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 28DAEEC5520; Sat, 6 Jan 2018 18:25:38 +0000 (UTC) (envelope-from osa@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 060EF799A7; Sat, 6 Jan 2018 18:25:38 +0000 (UTC) (envelope-from osa@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 975) id 4C01314E96; Sat, 6 Jan 2018 18:25:37 +0000 (UTC) Date: Sat, 6 Jan 2018 18:25:37 +0000 From: "Sergey A. Osokin" To: Adam Weinberger Cc: Mathieu Arnold , v@fatpipi.com, Jochen Neumeister , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r458000 - head/www/nginx Message-ID: <20180106182537.GA78102@FreeBSD.org> References: <201801031933.w03JXLGa033758@repo.freebsd.org> <20180106134130.GA39725@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Jan 2018 18:25:38 -0000 On Sat, Jan 06, 2018 at 08:15:16AM -0700, Adam Weinberger wrote: > > On 6 Jan, 2018, at 6:41, Sergey A. Osokin wrote: > > > > On Thu, Jan 04, 2018 at 08:30:55AM +0100, Mathieu Arnold wrote: > >> Le 04/01/2018 ?? 02:56, Vanilla Hsu a ??crit : > >>> auth-digest is not default module, so you don't need to bump > >>> PORTREVISION. > >> > >> Yes you do. > >> To quote > >> https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.html#makefile-portrevision > >> : > >> > >> PORTREVISION must be increased each time a change is made to the > >> port that changes the generated package in any way. That includes > >> changes that only affect a package built with non-default options. > > > > I've tried to find a commit in doc area to better understand who and why > > did this change. Another question is why this so important change > > hasn't been discussed and why committers and community haven't been > > notified > > about that in advance. > > Hi Sergey, > > It's been policy for a long time now, a number of years at least. It does > feel strange at first, but it really does benefit our users in the end. The > reason we have to bump PORTREVISION for non-default options is the same > reason we have to bump PORTREVISION for default options. When something > changes, build scripts need to know to rebuild the package. There is simply > no way for that to happen unless we tell them to. > > I know you're not a fan of forcing default option users to rebuild ports > when their setup hasn't changed, but the other side of it is that we often > force non-default option users to rebuild when THEIR setup hasn't changed. > It works both ways, and it's just a consequence of our build paradigm. It > has to happen though, every time. Hi Adam, thank you very much for so long answer with so many details, I think I understand your opinion in this case, however would you mind to provide a bit more details in this case (please review my questions)? Thanks in advance. -- Sergey A. Osokin