From owner-freebsd-hackers@FreeBSD.ORG  Mon Nov  8 18:49:47 2004
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AA6B016A4FA
	for <freebsd-hackers@FreeBSD.org>;
	Mon,  8 Nov 2004 18:49:44 +0000 (GMT)
Received: from mail2.speakeasy.net (mail2.speakeasy.net [216.254.0.202])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1B32E43D1D
	for <freebsd-hackers@FreeBSD.org>;
	Mon,  8 Nov 2004 18:49:44 +0000 (GMT)	(envelope-from jhb@FreeBSD.org)
Received: (qmail 31581 invoked from network); 8 Nov 2004 18:49:43 -0000
Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx)
	([216.27.160.63])          (envelope-sender <jhb@FreeBSD.org>)
	encrypted SMTP
	for <rionda@gufi.org>; 8 Nov 2004 18:49:43 -0000
Received: from [10.50.41.235] (gw1.twc.weather.com [216.133.140.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iA8Inamq019664;
	Mon, 8 Nov 2004 13:49:39 -0500 (EST)
	(envelope-from jhb@FreeBSD.org)
From: John Baldwin <jhb@FreeBSD.org>
To: freebsd-hackers@FreeBSD.org, rionda@gufi.org
Date: Mon, 8 Nov 2004 13:33:54 -0500
User-Agent: KMail/1.6.2
References: <1099904496.45709.36.camel@kaiser.sig11.org>
In-Reply-To: <1099904496.45709.36.camel@kaiser.sig11.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200411081333.54349.jhb@FreeBSD.org>
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx
Subject: Re: Little kbdmap.c diff
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Nov 2004 18:49:47 -0000

On Monday 08 November 2004 04:01 am, Matteo Riondato wrote:
> Hi folks,
>
> I would propose this little patch for usr.sbin/kbdmap/kbdmap.c :
>
> --- kbdmap.c.old        Sun Nov  7 21:22:08 2004
> +++ kbdmap.c    Sun Nov  7 21:33:53 2004
> @@ -288,7 +288,7 @@
>         if (!x11)
>                 system(kbd_cmd);
>
> -       printf("keymap=%s\n", km->keym);
> +       fprintf(stderr, "keymap=%s\n", km->keym);
>         free(kbd_cmd);
>  }
>
>
> With this patch, kbdmap will print user choice on stderr instead of
> stdout. This will make saving user preference really easier for FreeSBIE
> [1] and I think it's such a small thing that nobody would have any
> objection..
>
> [1] FreeSBIE (www.freesbie.org) is a project that aims to develope a
> FreeBSD based LiveCD.
>
> Best Regards
>
> P.S. CC'ed to wollman@ because he's the last one to have commited
> modification to kbdmap.c

Curious as to why printing to stderr helps?

-- 
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org