From owner-svn-src-all@freebsd.org  Sat Dec  5 17:26:17 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id AED4EA41296;
 Sat,  5 Dec 2015 17:26:17 +0000 (UTC)
 (envelope-from bjkfbsd@gmail.com)
Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com
 [IPv6:2a00:1450:400c:c09::233])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4CAFE1B71;
 Sat,  5 Dec 2015 17:26:17 +0000 (UTC)
 (envelope-from bjkfbsd@gmail.com)
Received: by wmww144 with SMTP id w144so96286365wmw.1;
 Sat, 05 Dec 2015 09:26:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=OfrsDiLkd+iae8RLRQvQQ2NaG9oTArg8hiEn/u9iJ0U=;
 b=Wrnr3bFGff9X9ViZV5on1c9NEMey/2hkaDe2+HhrPg080N6hjJQQTLfcmXjzdqs93S
 CGJyStc2UZ86Nlb9HK75by0AlnaSl1iyenl2RyAuQea+YMpe9DIV+1F1evbVc6nf39kl
 m6CK8wJbzrbFU1V/J7zXK9IRIVdqdMPKcMuoQISSWHBH0EVeITfxcPy9rBV4Vl6gPnK0
 Og6jv1RyYEd1gMdv46RFDQnkmKI9M3cDst4fh+GvHGJe3wcbubZ40vz3wTAFnUJE890+
 8QDGg4niFjSWB6DMYybVUtKWwzuJe69eEw8ISFIf+0fC8rIskuvBRsJkjKavU0WvLwtk
 IgSw==
MIME-Version: 1.0
X-Received: by 10.194.79.201 with SMTP id l9mr26780864wjx.151.1449336375835;
 Sat, 05 Dec 2015 09:26:15 -0800 (PST)
Received: by 10.27.10.199 with HTTP; Sat, 5 Dec 2015 09:26:15 -0800 (PST)
In-Reply-To: <201512051628.tB5GSEnr024370@repo.freebsd.org>
References: <201512051628.tB5GSEnr024370@repo.freebsd.org>
Date: Sat, 5 Dec 2015 11:26:15 -0600
Message-ID: <CAJ5_RoBhMb1UBqaSbzShT7Qw7hNhjQQuSusdWOL_7QWdgd3O1g@mail.gmail.com>
Subject: Re: svn commit: r291860 - in head/tools/tools/nanobsd: . embedded
From: Benjamin Kaduk <bjkfbsd@gmail.com>
To: Warner Losh <imp@freebsd.org>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.20
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Dec 2015 17:26:17 -0000

On Sat, Dec 5, 2015 at 10:28 AM, Warner Losh <imp@freebsd.org> wrote:

> Author: imp
> Date: Sat Dec  5 16:28:14 2015
> New Revision: 291860
> URL: https://svnweb.freebsd.org/changeset/base/291860
>
> Log:
>   Stupid last minute changes: Add missing } and fi
>
>   Pointed out by: Howard Su
>
> Modified:
>   head/tools/tools/nanobsd/defaults.sh   (contents, props changed)
>   head/tools/tools/nanobsd/embedded/common
>
> Modified: head/tools/tools/nanobsd/defaults.sh
>
> ==============================================================================
> --- head/tools/tools/nanobsd/defaults.sh        Sat Dec  5 15:09:19 2015
>       (r291859)
> +++ head/tools/tools/nanobsd/defaults.sh        Sat Dec  5 16:28:14 2015
>       (r291860)
> @@ -961,7 +961,7 @@ set_defaults_and_export ( ) {
>         [ ! -d "${NANO_TOOLS}" ] && [ -d "${NANO_SRC}/${NANO_TOOLS}" ] && \
>                 NANO_TOOLS="${NANO_SRC}/${NANO_TOOLS}" || true
>
> -       [ ! -z "${NANO_NOPRIV_BUILD" ] && [ -z "${NANO_METALOG}"] && \
> +       [ ! -z "${NANO_NOPRIV_BUILD}" ] && [ -z "${NANO_METALOG}"] && \
>

Hmm, is there still a missing space between '"' and ']' in the second
clause?

-Ben


>                 NANO_METALOG=${NANO_OBJ}/_.metalog || true
>