Date: Sun, 28 Jul 2013 20:52:30 -0700 From: Tim Kientzle <kientzle@freebsd.org> To: Jason Helfman <jgh@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r323836 - in head/devel: . arm-eabi-binutils arm-eabi-binutils/files Message-ID: <B6C67E6C-D548-4B6D-8A3E-AB55EA0CCB62@freebsd.org> In-Reply-To: <CAMuy=%2BhFpUQRRkOgi0KEktqpFyNyX=6OTyP5rmSEsGqWo4A85w@mail.gmail.com> References: <201307281645.r6SGjNAs020031@svn.freebsd.org> <CAMuy=%2BhFpUQRRkOgi0KEktqpFyNyX=6OTyP5rmSEsGqWo4A85w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jul 28, 2013, at 12:09 PM, Jason Helfman wrote: > On Sun, Jul 28, 2013 at 9:45 AM, Tim Kientzle <kientzle@freebsd.org> = wrote: > Author: kientzle (src committer) > Date: Sun Jul 28 16:45:22 2013 > New Revision: 323836 > URL: http://svnweb.freebsd.org/changeset/ports/323836 >=20 > Log: > Add arm-eabi-binutils cross-tools. >=20 > Approved by: db >=20 > Added: head/devel/arm-eabi-binutils/Makefile > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/devel/arm-eabi-binutils/Makefile Sun Jul 28 16:45:22 = 2013 (r323836) > @@ -0,0 +1,47 @@ > +# $FreeBSD$ > + > +PORTNAME=3D binutils > +PORTVERSION=3D 2.23.2 > +CATEGORIES=3D devel > +MASTER_SITES=3D ${MASTER_SITE_SOURCEWARE} > +MASTER_SITE_SUBDIR=3D binutils/releases > +PKGNAMEPREFIX=3D arm-eabi- > + > +MAINTAINER=3D kientzle@gmail.com > +COMMENT=3D GNU binutils for vanilla ARM cross-development > + > +.if !defined(WITHOUT_NLS) > +USE_GETTEXT=3D yes > +PLIST_SUB+=3D NLS=3D"" > +.else > +CONFIGURE_ARGS+=3D --disable-nls > +PLIST_SUB+=3D NLS=3D"@comment " > +.endif > +USE_BZIP2=3D yes > +USE_GMAKE=3D yes > +USES=3D gettext > +GNU_CONFIGURE=3D yes >=20 >=20 > Is there any particular reason that bsd.port.options.mk wasn't = included here? >=20 > USE_GETTEXT is deprecated, and should be using the USES framework to = bring in the dependency. The only reason this dependency is working is = that it is unconditionally brought in with the USES framework later in = the Makefile. >=20 > To this affect, if NLS is disabled, it brings in gettext dependency. = Can it be disabled? >=20 > USE_GMAKE can be converted, as well, to the USES framework. (USES=3D = gmake) >=20 > .include <bsd.port.options.mk> >=20 > .if ${PORT_OPTIONS:MNLS} > USES+=3D gettext > ... > .endif=20 Jason, Please take a look at this updated version and let me know if it addresses your concerns: https://redports.org/browser/kientzle/devel/arm-eabi-binutils/Makefile
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B6C67E6C-D548-4B6D-8A3E-AB55EA0CCB62>