From nobody Thu Mar 7 14:15:30 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TrBCn73HSz5D5r6; Thu, 7 Mar 2024 14:15:33 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TrBCn5RvRz3ymH; Thu, 7 Mar 2024 14:15:33 +0000 (UTC) (envelope-from mat@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709820933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sYiOPLmqsHDXBkZQNHSPEBXe9MkBbG3LYj30GM8TCl0=; b=FVfl/Ygt0spEGFqJjqMiHLGJysNjXJkdbaKnEepssYG+LiV9xWQ3zLwlinM/rLBbmVtYJ0 RUxjuD3wuD57YN7xitWI7yaGqLqEU1Wz5kIKgkq0UNa2F0j4nsREmE6fFIOOu0T4vQklPX M8olyV4zrA1MEVn0/KGdLno2xS33T2X/IWGTWEukrwQrT9w2O83r3miMiuDDKfhRGKGEov U3X4QlrlNFRQRBQWhIWOVJYnIPTwWO3q29eceTYCudTsJJdDs6NAmOt46z6p+h/7X/NcGW OSAwxOKatI4e7PHLmXWYdqWqSDvFe3oZRHVfHvgJcgntBkwRtwytVOXsfNcs1g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1709820933; a=rsa-sha256; cv=none; b=Px6UVA3KKIh6GkEyr+XrEMwK5TmZPlsXL0cB8ilXO0IaPqoE7ovPSf4jR8xT5dUXMzyRId /m6yLRR09tZ0LdruUsger31jndErgR6aFlqaShw78ysSKeKJ+lAw/RJZqzTptJ+HoicZxt gHlz8s+qbSuAUeJiRljVbSZx1cRG7WgDU6f/nCB1zZDMo8ONy0jSXhNc+/9HvR+euQWZ3O KMFjYBNFm45ka1AhxtOO6AVcM4eyFNJi1ZeDQqC4NbJJHhGjxcEWesRAAZPLPPVrF2SabI utBiyjHBBuXRp1PcT6AJlUHYcvJwLaRkKUv98/mi1c0WKckl0J8Q9Q1eetnRhA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709820933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sYiOPLmqsHDXBkZQNHSPEBXe9MkBbG3LYj30GM8TCl0=; b=JA3afWGuqjIeMYlcpwyAKY+rw959cAHZfpfFmAgBeumWZ+biLqa3hymAGcYJPdUkxuR95E km8MU5eVzfwBsHli+3rxPpiIgFv2HMvgvU1t8brFwfVMkFag4Y3x+cIOJvcp+YaRqBXYnm nzzEanN0+Q8PEgdqNxr47GkhhW2pF5EBNnajs/zkuS7/4zUr1SaaxUCMCO5MfYql52Uyw+ RiCQmLeNt8baLN3K56zkKV5A+aciofBjEl2GrDLI8D+YeWS6KlAcN+i0HxmpZ7yfJECLO/ nKgKvVQY+LziDsk2UGwLYV+6UpsarHzgutRy8fZv3QAWBxzc8CxmtfNFwf7gZg== Received: from relay.mat.cc (cow.mat.cc [79.143.244.49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "cow.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TrBCn4K4fz16fn; Thu, 7 Mar 2024 14:15:33 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:678:ab:50:716:1ded:630c:7c39]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by relay.mat.cc (Postfix) with ESMTPSA id 8EAEA20E0D; Thu, 7 Mar 2024 15:15:32 +0100 (CET) Date: Thu, 7 Mar 2024 15:15:30 +0100 From: Mathieu Arnold To: Fernando =?utf-8?Q?Apestegu=C3=ADa?= Cc: Daniel Engberg , Daniel Engberg , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ea45a9a53499 - main - cad/PrusaSlicer: Mark BROKEN Message-ID: References: <202403031936.423JaMcm054153@gitrepo.freebsd.org> <0d76f19c6d2e3e2b70a2ccc07c71e1ce@mail.infomaniak.com> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5ie7ycna73r3o3ys" Content-Disposition: inline In-Reply-To: --5ie7ycna73r3o3ys Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 07, 2024 at 12:22:09PM +0100, Fernando Apestegu=C3=ADa wrote: > On Wed, Mar 6, 2024 at 10:34=E2=80=AFPM Daniel Engberg < > daniel.engberg.lists@pyret.net> wrote: >=20 > > On 2024-03-04T18:34:16.000+01:00, Fernando Apestegu=C3=ADa < > > fernando.apesteguia@gmail.com> wrote: > > > On Sun, Mar 3, 2024 at 8:36=E2=80=AFPM Daniel Engberg > > wrote: > > > > > > > > > > The branch main has been updated by diizzy: > > > > > > > > URL: > > > > > > https://cgit.FreeBSD.org/ports/commit/?id=3Dea45a9a534994a1bf97a1621689= 02cebbca1f4c1 > > > > > > > > commit ea45a9a534994a1bf97a162168902cebbca1f4c1 > > > > Author: Daniel Engberg > > > > AuthorDate: 2024-03-03 08:29:04 +0000 > > > > Commit: Daniel Engberg > > > > CommitDate: 2024-03-03 19:26:10 +0000 > > > > > > > > cad/PrusaSlicer: Mark BROKEN > > > > > > > > Fails to build, error: no member named 'prior' in namespace > > 'boost' > > > > > > > > Reported by: pkg-fallout > > > > --- > > > > cad/PrusaSlicer/Makefile | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/cad/PrusaSlicer/Makefile b/cad/PrusaSlicer/Makefile > > > > index dc125244df20..936e76216daf 100644 > > > > --- a/cad/PrusaSlicer/Makefile > > > > +++ b/cad/PrusaSlicer/Makefile > > > > @@ -12,6 +12,8 @@ WWW=3D https://www.prusa3d.com/prusasli= cer/ > > > > LICENSE=3D AGPLv3 > > > > LICENSE_FILE=3D ${WRKSRC}/LICENSE > > > > > > > > +BROKEN=3D fails to build, error: no member named > > 'prior' in > > > > namespace 'boost' > > > > + > > > > > > > > > > Can we revert this? > > > It is an issue with math/cgal and not cad/PrusaSlicer ( > > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277480) > > > > > > > Cheers. > > > > > > > > > > > > > BUILD_DEPENDS=3D cereal>=3D1.3.0.10:devel/cereal \ > > > > cgal>=3D5.0.2:math/cgal \ > > > > opencascade>=3D7.7.0:cad/opencascade > > > > > > > Hi, > > > > It breaks Prusaslicer either way? > > > > https://pdr2.bofh.network/data/140-diizzy/2024-03-02_16h50m15s/logs/err= ors/PrusaSlicer-2.6.0_8.log >=20 >=20 > I just realized I didn't attach the patch to the PR :S > It is attached now. > With that patch in math/cgal, cad/PrusaSlicer builds fine. >=20 > My main point is this. We should mark ports as BROKEN when *they* are > broken, not when the dependencies are. In this case, the dependency was not broken in the sense that it built just fine. We mark ports BROKEN because they don't build, so that the FreeBSD ports infrastructure does not spend hours trying to build stuff that will never build. --=20 Mathieu Arnold --5ie7ycna73r3o3ys Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmXpzABfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb6TAgv/X7jJeMdimL+NAvs4dgrQQ2aBjx2IrVwU/pMOdS0Q55q1cdl5ZBefEUEY vAxjX5YUVQArADCFd1J2lFPhHkkDhLoV6Sdb9di7oJWSETPwZNAeKLusru6PV31+ 86deunEjh13rH+r8qUAbEjbz46vbnl9pmSqRp1MUTUZHnRbeIiS99PtGqjr2Zl6w /GSyZQg+LMyXfucrSofNvLDo9KQN5zkbSgB55Lww0Xa0//9jgibwT1wlE0HmN1UO HYPbFdKMXjLX+Fm409rDkk0M5gMTGVMb/IJmCvqvjJMJ1OAUggIv76eS0rAL/97X HfY3LGA+0sa0ceulZQFY+yXrkd4ISl4wig3XDDzkzIULsdjeD9wHuomMvZBSN+LU dZvhPQ8ohfVvKburN2fUPDxREdgvbjArBeVuUPNLCJWKAeOKWD9AxVr4stuVAywE duigLCzeUgar3pw2ByKSDlZGWnNhoW4nhVDw7I7+uQ+qiS3ypRfV4/5lEGeNinFl IjNbM0pa =d/nT -----END PGP SIGNATURE----- --5ie7ycna73r3o3ys--