From owner-freebsd-current Sun Dec 31 18: 4:52 2000 From owner-freebsd-current@FreeBSD.ORG Sun Dec 31 18:04:51 2000 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from earth.backplane.com (placeholder-dcat-1076843399.broadbandoffice.net [64.47.83.135]) by hub.freebsd.org (Postfix) with ESMTP id E9E0637B400; Sun, 31 Dec 2000 18:04:50 -0800 (PST) Received: (from dillon@localhost) by earth.backplane.com (8.11.1/8.9.3) id f0124oW47215; Sun, 31 Dec 2000 18:04:50 -0800 (PST) (envelope-from dillon) Date: Sun, 31 Dec 2000 18:04:50 -0800 (PST) From: Matt Dillon Message-Id: <200101010204.f0124oW47215@earth.backplane.com> To: John Baldwin Cc: current@FreeBSD.ORG Subject: Re: Current hangs... References: Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG : :Why not this: : :s = splbio(); :TAILQ_FOREACH(bp, &vp->v_dirtyblkhd, b_vnbufs) { First rule when making simple bug fixes by copying working code from one source file to another is: Dont try to optimize the code on the fly. Personally speaking, I don't find the FOREACH macros any more readable vs an explicit for loop. They hide too much... like for example the fact that you are dependant on the current pointer remaining valid to get the next pointer in the loop. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message