From owner-svn-ports-all@FreeBSD.ORG  Mon Aug  5 17:41:22 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id EA8A6970; Mon,  5 Aug 2013 17:41:22 +0000 (UTC)
Date: Mon, 5 Aug 2013 17:41:22 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Adam Weinberger <adamw@adamw.org>
Subject: Re: svn commit: r324179 - in head/devel: . acme
Message-ID: <20130805174122.GC85683@FreeBSD.org>
References: <201308030733.r737XGXd008385@svn.freebsd.org>
 <20130804163529.GA22214@FreeBSD.org>
 <2EBAFAC2-5B08-4892-A330-4AF80CC2A651@adamw.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2EBAFAC2-5B08-4892-A330-4AF80CC2A651@adamw.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 Jason Helfman <jgh@FreeBSD.org>, ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Aug 2013 17:41:23 -0000

On Mon, Aug 05, 2013 at 11:02:38AM -0400, Adam Weinberger wrote:
> On 2013-08-04, at 12:35, Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
> > On Sat, Aug 03, 2013 at 07:33:16AM +0000, Jason Helfman wrote:
> >> +PLIST_FILES=	bin/acme \
> >> +		%%DATADIR%%/6502 \
> >> +		%%DATADIR%%/6502/Help.txt \
> >> +		%%DATADIR%%/6502/std.a \
> >> +		%%DATADIR%%/65816 \
> >> +		%%DATADIR%%/65816/Help.txt \
> >> +		%%DATADIR%%/65816/std.a \
> >> +		%%DATADIR%%/Own \
> >> +		%%DATADIR%%/Own/Help.txt
> >> +PLIST_DIRSTRY=	%%DATADIR%%/6502 \
> >> +		%%DATADIR%%/65816 \
> >> +		%%DATADIR%%/Own \
> >> +		%%DATADIR%%
> > 
> > Typically using PLIST_* makes sense for short (like, five or so) entries;
> > in this case I would say that traditional pkg-plist should have been used.
> 
> I think the problem here is that he has directories listed in both
> PLIST_FILES and PLIST_DIRSTRY.

Indeed, slipped through my eyes.  Apparently, the fact of misused PLIST_*
knobs was good enough reason to skip deeper analysis. :-)

./danfe