Date: Mon, 2 Jul 2018 03:25:06 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Mark Linimon <linimon@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r473698 - head/emulators/simh Message-ID: <20180702032506.GA73255@FreeBSD.org> In-Reply-To: <201807020308.w6238vSs002453@repo.freebsd.org> References: <201807020308.w6238vSs002453@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 02, 2018 at 03:08:57AM +0000, Mark Linimon wrote: > New Revision: 473698 > URL: https://svnweb.freebsd.org/changeset/ports/473698 > > Log: > Attempt to see if the build can be fixed on non-clang-based archs. > > [...] > +.include <bsd.port.pre.mk> > + > +.if ${ARCH} == aarch64 || ${ARCH} == amd64 || ${ARCH} == armv6 || ${ARCH} == armv7 || ${ARCH} == i386 > +CFLAGS+= -Wno-logical-op-parentheses -Wno-bitwise-op-parentheses -Wno-shift-negative-value > +.endif Hmm, perhaps a better approach would've been to USES+=compiler:env and set CFLAGS based on COMPILER_TYPE (or is it CHOSEN_COMPILER_TYPE?) rather than hardcode all those arch names. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180702032506.GA73255>