Date: Sun, 6 May 2018 15:10:57 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org> Cc: Koichiro Iwao <meta@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r469188 - head/ports-mgmt/pkg_replace Message-ID: <20180506151057.GA79630@FreeBSD.org> In-Reply-To: <CC3C2D9C-F9B7-48DE-A53B-D9193C6CE65E@adamw.org> References: <201805061015.w46AF3HQ070595@repo.freebsd.org> <20180506102749.GA58637@FreeBSD.org> <CC3C2D9C-F9B7-48DE-A53B-D9193C6CE65E@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, May 06, 2018 at 08:41:36AM -0600, Adam Weinberger wrote: > > On 6 May, 2018, at 04:27, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: > > ... > > Correct PLIST_FILES should read: > > > > PLIST_FILES= sbin/pkg_replace \ > > man/man1/pkg_replace.1.gz \ > > @sample\ etc/pkg_replace/pkg_replace.conf.sample > > Sorry, Alexey, but portlint was right here. @sample and other macros > should *never* appear in PLIST_FILES. Even if the port installs only a > single file, if it's a @sample, it goes in pkg-plist. Hmm, that's news to me; I'm pretty sure I've used @sample in PLIST_FILES, verified generated package, and it came out as expected. I've also seen others doing the same. Admittedly I didn't check this particular example I've written above, but I don't recall recent changes to the framework that would forbit keywords from appearing on PLIST_FILES. I was under impression that LICENSE[_FILE], PLIST_FILES, PORTDOCS et al. are mixed together prior to keyword expansion. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180506151057.GA79630>