From owner-svn-ports-all@freebsd.org Sun May 6 15:10:59 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 84378FBC818; Sun, 6 May 2018 15:10:59 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7F7E46C2BC; Sun, 6 May 2018 15:10:58 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id C9AD0EBA9; Sun, 6 May 2018 15:10:57 +0000 (UTC) Date: Sun, 6 May 2018 15:10:57 +0000 From: Alexey Dokuchaev To: Adam Weinberger Cc: Koichiro Iwao , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r469188 - head/ports-mgmt/pkg_replace Message-ID: <20180506151057.GA79630@FreeBSD.org> References: <201805061015.w46AF3HQ070595@repo.freebsd.org> <20180506102749.GA58637@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 May 2018 15:10:59 -0000 On Sun, May 06, 2018 at 08:41:36AM -0600, Adam Weinberger wrote: > > On 6 May, 2018, at 04:27, Alexey Dokuchaev wrote: > > ... > > Correct PLIST_FILES should read: > > > > PLIST_FILES= sbin/pkg_replace \ > > man/man1/pkg_replace.1.gz \ > > @sample\ etc/pkg_replace/pkg_replace.conf.sample > > Sorry, Alexey, but portlint was right here. @sample and other macros > should *never* appear in PLIST_FILES. Even if the port installs only a > single file, if it's a @sample, it goes in pkg-plist. Hmm, that's news to me; I'm pretty sure I've used @sample in PLIST_FILES, verified generated package, and it came out as expected. I've also seen others doing the same. Admittedly I didn't check this particular example I've written above, but I don't recall recent changes to the framework that would forbit keywords from appearing on PLIST_FILES. I was under impression that LICENSE[_FILE], PLIST_FILES, PORTDOCS et al. are mixed together prior to keyword expansion. ./danfe