From owner-freebsd-bugs Wed Dec 19 5:50:15 2001 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 2643137B417 for ; Wed, 19 Dec 2001 05:50:02 -0800 (PST) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id fBJDo2k62146; Wed, 19 Dec 2001 05:50:02 -0800 (PST) (envelope-from gnats) Date: Wed, 19 Dec 2001 05:50:02 -0800 (PST) Message-Id: <200112191350.fBJDo2k62146@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Peter Pentchev Subject: Re: bin/32953: log-in-vain level should be setable in rc.conf Reply-To: Peter Pentchev Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR bin/32953; it has been noted by GNATS. From: Peter Pentchev To: Ruslan Ermilov Cc: freebsd-gnats-submit@FreeBSD.org Subject: Re: bin/32953: log-in-vain level should be setable in rc.conf Date: Wed, 19 Dec 2001 15:46:39 +0200 On Tue, Dec 18, 2001 at 05:00:03AM -0800, Ruslan Ermilov wrote: > On Mon, Dec 17, 2001 at 05:40:02PM -0800, Crist J . Clark wrote: > > The following reply was made to PR bin/32953; it has been noted by GNATS. > > On Mon, Dec 17, 2001 at 04:28:07PM -0800, David O'Brien wrote: > > > > > >Description: > > > We allow the turning off and on of log-in-vain in rc.conf as seen in > > > rc.network: > > > > > > network_pass4() { > > > echo -n 'Additional TCP options:' > > > case ${log_in_vain} in > > > > > > Therefor we should also allow the log-in-vain level to be set in > > > rc.conf also. > > [snip] > > > > We should. How about this simple change which is back compaitible, but > > does not add more rc.conf knobs: > > > > Index: rc.network > > =================================================================== > > RCS file: /export/ncvs/src/etc/rc.network,v > > retrieving revision 1.119 > > diff -u -r1.119 rc.network > > --- rc.network 13 Dec 2001 04:21:18 -0000 1.119 > > +++ rc.network 18 Dec 2001 01:26:07 -0000 > > @@ -848,9 +848,12 @@ > > [Nn][Oo] | '') > > ;; > > *) > > - echo -n ' log_in_vain=YES' > > - sysctl net.inet.tcp.log_in_vain=1 >/dev/null > > - sysctl net.inet.udp.log_in_vain=1 >/dev/null > > + if ! expr "${log_in_vain}" : '[0-9]*' >/dev/null 2>&1; then > > + log_in_vain=1 > > + fi > > + echo -n " log_in_vain=${log_in_vain}" > > + sysctl net.inet.tcp.log_in_vain="${log_in_vain}" >/dev/null > > + sysctl net.inet.udp.log_in_vain="${log_in_vain}" >/dev/null > > ;; > > esac > > > I think you should add a case for [Yy][Ee][Ss], and treat the fallback > case as a numeric value, without expr(1)-checking it. There's nothing > wrong here as the only documented values were YES and NO, and people > who had it set to the other value (e.g. "YUP") will now have to fix it > to the right value. :-) Why would they have to fix it? This patch treats all non-numeric values as a default log level of 1; a "YUP" would be treated just the same as a "YES". I personally would prefer the expr regexp to be '[0-9]*$', though, because '[0-9]*' also catches things like '3foo', which is, strictly speaking, incorrect, although sysctl(8) silently trims at the first non-numeric character. G'luck, Peter -- What would this sentence be like if it weren't self-referential? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message