From owner-svn-src-all@freebsd.org Mon Aug 1 15:36:16 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 793B3BAB373 for ; Mon, 1 Aug 2016 15:36:16 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm29-vm1.bullet.mail.bf1.yahoo.com (nm29-vm1.bullet.mail.bf1.yahoo.com [98.139.213.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2FE1714D6 for ; Mon, 1 Aug 2016 15:36:15 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1470065414; bh=sDZCzXy7S9eOhYdZwTxWGfegD+/YU60Axfp9drvdc+4=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=dlKI0ytV5nxgeMF06TjnnHjD6dvxGb5yBS3lSChHFMTkgUAmu0ie5qr/+3Px0sNg1n/UCYylkN6UYIA8HS5qO2xS69n0oGs7W5o5dYPMD5Kc/mOarinCcYJh9DSWGG9auAbdAd4yMK+zdwwNqfOg3USB3E/CLXkgdl7sfKi+QB5lMMF21InpZCISlsRaFoZ+sPZ6iUxGApP6cPHPKwHDQj5zZAE3nSdk0i2JNJoVYy/5zBtaBAWp9yl/ExlWDE1QPK/q6D1ZtxGnZACnCa30kDEssOS2eAqFbZ5W7dYsbNdk8LdqlaGudVya0+nTNLiEL4uT2GX7dtafUz360RtNWA== Received: from [66.196.81.174] by nm29.bullet.mail.bf1.yahoo.com with NNFMP; 01 Aug 2016 15:30:14 -0000 Received: from [98.139.211.198] by tm20.bullet.mail.bf1.yahoo.com with NNFMP; 01 Aug 2016 15:30:14 -0000 Received: from [127.0.0.1] by smtp207.mail.bf1.yahoo.com with NNFMP; 01 Aug 2016 15:30:14 -0000 X-Yahoo-Newman-Id: 31761.84967.bm@smtp207.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: A1WzkpIVM1mAKIg0gDIUOBRI5bZYj6NzXWU9tSfWl4KOpkg CfvziYEawe_vib221N9h02Yy4F_5fp0eNBK.pCpQPCtpkwmpEkNsIPZspKmn o7FLxOCC42uuA9hT_4H_JSfnqqL0MnRuKoJgD0Jn_eTDrO8.ohLzl_KvCu_U wnCeJK5z_IRXHgC9OZP.MvfW6oRGZQ3tcL9U0XBQ3CbMTCaBGpXbK25TvFj7 IUqWSknJD1fVwkJOw42E3qBiUZsXMAFS2_ZMh2tsk5N5iONVluDhwHegt8.Z oVFzxa7dihaUHdoz1NA.p61Wg2e7_7UjkecyEjgusMaXdaM.JuOSYbgj8rlv 9B8aeYEbK_OP9iJ0AXAo2TL67u_EnjEok3DR1iavpUP0XEG64qgcvUZkKbtY 7j3.cIAoegBunOUYYLLgTdhAf3.mQ7avsmgXRPOIz5QHZD_TNtLfzv67oLEp hUynQkI6Xj0qGR_PUTv6PqC3WCeA7e4SRxii_jMPnR7dc.8_5nMhsyCNR_vH 6IyL8Pe_VRqVBvCD.wbB1mGiHX6G_sPC5LZb4d.3BI03kog-- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r303600 - head/usr.bin/indent To: Xin Li , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201607312136.u6VLaeRb058693@repo.freebsd.org> <8d6114b7-cd71-239a-dcc4-03a6d568482c@delphij.net> Cc: d@delphij.net From: Pedro Giffuni Message-ID: <3eb7a9fe-f80d-7d34-c78e-df11e4a6aeb4@FreeBSD.org> Date: Mon, 1 Aug 2016 10:30:26 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <8d6114b7-cd71-239a-dcc4-03a6d568482c@delphij.net> Content-Type: multipart/mixed; boundary="------------F06810B83B1DA26EB4E2C552" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2016 15:36:16 -0000 This is a multi-part message in MIME format. --------------F06810B83B1DA26EB4E2C552 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 08/01/16 00:28, Xin Li wrote: > > > On 7/31/16 14:36, Pedro F. Giffuni wrote: >> Author: pfg >> Date: Sun Jul 31 21:36:40 2016 >> New Revision: 303600 >> URL: https://svnweb.freebsd.org/changeset/base/303600 >> >> Log: >> indent(1): replace function call to bzero with memset. >> >> Reference: >> https://github.com/pstef/freebsd_indent/commit/7422f42f80099c69d34833d7106035dc09230235 >> >> Differential Revision: https://reviews.freebsd.org/D6966 (Partial) >> Submitted by: Piotr Stefaniak >> >> Modified: >> head/usr.bin/indent/io.c >> >> Modified: head/usr.bin/indent/io.c >> ============================================================================== >> --- head/usr.bin/indent/io.c Sun Jul 31 21:29:10 2016 (r303599) >> +++ head/usr.bin/indent/io.c Sun Jul 31 21:36:40 2016 (r303600) >> @@ -629,7 +629,7 @@ parsefont(struct fstate *f, const char * >> const char *s = s0; >> int sizedelta = 0; >> >> - bzero(f, sizeof *f); >> + memset(f, 0, sizeof(struct fstate)); > ^^^^^^^^^^^^^^^^^^^^^ This is much more error-prone > than sizeof(*f) IMHO. > > Cheers, > Does this look better? Cheers, Pedro. --------------F06810B83B1DA26EB4E2C552 Content-Type: text/x-patch; name="indent-memset.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="indent-memset.diff" Index: usr.bin/indent/io.c =================================================================== --- usr.bin/indent/io.c (revision 303615) +++ usr.bin/indent/io.c (working copy) @@ -629,7 +629,7 @@ const char *s = s0; int sizedelta = 0; - memset(f, 0, sizeof(struct fstate)); + memset(f, '\0', sizeof(*f)); while (*s) { if (isdigit(*s)) f->size = f->size * 10 + *s - '0'; --------------F06810B83B1DA26EB4E2C552--