From owner-svn-src-all@freebsd.org Mon Jun 1 06:18:36 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 80E2732B79A; Mon, 1 Jun 2020 06:18:36 +0000 (UTC) (envelope-from ohartmann@walstatt.org) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49b4k334Bvz4Cy7; Mon, 1 Jun 2020 06:18:35 +0000 (UTC) (envelope-from ohartmann@walstatt.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1590992313; bh=5eNx+Ws/eIIY1/SmLO/0+rQSj62YWQnAMend/x7Ltt8=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References; b=MkXVCYDUFvhgxIRpZXdK4jlnrks8WfW+1qnv1tPTLF+b9K5jnXBDT30t8vh37oCwG kJoJ1T7GU56Kg2Vg4mS6dsMp7KsPr/j9RgHxwvmy3Q/sBeH0/I9Ya+dUQ9buKcLTRb LbchzB2O/mMBMaRJFNEQBTg4QpOxpJFnUOXeTwcc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from hermann.fritz.box ([77.11.115.59]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MfpOd-1j4Lwn2drt-00gEt3; Mon, 01 Jun 2020 08:18:32 +0200 Date: Mon, 1 Jun 2020 08:18:24 +0200 From: "Hartmann, O." To: "Hartmann, O." Cc: John Baldwin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r361633 - in head/sys: net netipsec Message-ID: <20200601081810.79c9fb1d@hermann.fritz.box> In-Reply-To: <20200531114318.2b415934@hermann.fritz.box> References: <202005291922.04TJMemQ098017@repo.freebsd.org> <20200531114318.2b415934@hermann.fritz.box> Organization: walstatt.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/OrJnGUcm8Wr1o6kmQJCtzC4"; protocol="application/pgp-signature" X-Provags-ID: V03:K1:l+IRWm4Q1IDTcGuzY0DujcpWraVIsI5XTZz48G1hb1i0t9I6hC4 p8lMD3+NT+MNMvXhvb+zmZnS2mi97JFcL19I63MfYg2A9Fa3nUHn6kuQ3kDLTazTW6Gp0bz Jikr1YA/a+KzrCX9Pw5tVv3L1x4goWFoXiHyZAQjkXKqJ4PYg+C6rNm9a7HT5C3wGJpuNFw IN7tkISQWJkN9+x/9tzwQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:4j9GdYTnaRg=:SXCNnqcS18EtoFb1CYf8Vv DCAcoDbCf1O/bcSEq2fOEO5lKqKhBEAc70riFT1w8gruleyzWDntu5LpLI6HA01YMIGtrvkZQ iciwNW2lgh7p7eJgWt9TuVvb2/eMrDppXmLbtpzxpb30lkrKm5rmNCN4xaNe01srCe1AXnLQs 6vEahBcyPiAR4PETv7VuOEM5uhS2TRx0M2/heELhhXLpegUvEFr15MAOD3Uh8uG0Jm6C6ml5e poo5tqc62iXc4uTb0ZHL4rFPHXGbSOXiiMbGI5Mpn6raknJKqB79QWT4tKk6MK2l4TYjHzaSm zX02xXspez+6JIkLymDKXxQSWElhtt/t2hX7soEq5PiZrvgCrFCKpWRb0WGjJNgZmQMlmmheV B6oLjz4gvxAfBlHcEFXPpWtSEft/X6FUJ5g2RKCDDEezxOHi7v4fhUbF0eVHPR8Pkcg36VBGw wazfGRqZVzI8rPs/sA6laeemC0AOvXihSwaeq+GOoIypazHLwnkmOnGRxTO01glBSuvuZjGsW JdqSiABswF4snt4MwxYpsGgY9gIZ/IPIhDEEWVpLDGDcNTvvJ5PQL2V/VYSWq+0kbhDv2KloD adPMikouQFpapM+DkkVWRWr7Qn373hgR/Z44uhB+8x/h/vfqer1TPxmewapj94jqlSrzEwWtO MrLbIz7uCrLOYFZROuMKQG+SiHdyJqjkXTEXe8J1NPRkByiWQEp5c9hkps6n/nxhXLRka7jGt 2RSmPzvxmxSb7IWH2g+5PNI50TDvO0Q0hANue3iLA10VuvgDt4w9jnx/KbXtVvoyMBi3bZCd4 ONUXZRgJpoe8SJm/4HAZ01f+fKmJPajABChffc8j+QsceJwSiM75XojLWOGfelUdaxkHYEIGR OiduWNKHK8+dXHPsAJSWnp6PwHFH0B+ktdamU2hvIW2Ot24ECfMSc87XsBGPD9wwkgsFLXkfw UVViysNk95+IB1gRtjIZH61pB+2ST0YGUZKryhVsZcUhwR1lDZ4ni5kcTZ2WPqJ030b6KVQFy 0hyemc2Novy1XDYosDXBhTMKXSPSsNNVI6vcNmneoHVkr0+97SYACpZiNinET05pTIB1xuGZu Sv0cJT9C1ylkOfxnoa8q4MdujV7+8lURbwMT5GtiLMhjYa6/UJ9rrnY0oEYsMEngIwUXf7TBd 08vta2DSATBF33K45sQBKAp9nP4icJbaV3CwHYKKmf5I/YeK/oWC/0o7+yQSogOsLrDbiKpcC qzNtP69DizyNzTAkl X-Rspamd-Queue-Id: 49b4k334Bvz4Cy7 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmx.net header.s=badeba3b8450 header.b=MkXVCYDU; dmarc=none; spf=none (mx1.freebsd.org: domain of ohartmann@walstatt.org has no SPF policy when checking 212.227.15.19) smtp.mailfrom=ohartmann@walstatt.org X-Spamd-Result: default: False [-2.33 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RWL_MAILSPIKE_NEUTRAL(0.00)[212.227.15.19:from]; R_DKIM_ALLOW(-0.20)[gmx.net:s=badeba3b8450]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-0.89)[-0.886]; NEURAL_HAM_LONG(-0.84)[-0.841]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[walstatt.org]; RCPT_COUNT_FIVE(0.00)[5]; HAS_ORG_HEADER(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[77.11.115.59:received]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmx.net:+]; NEURAL_HAM_SHORT(-0.11)[-0.108]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_COUNT_TWO(0.00)[2]; ASN(0.00)[asn:8560, ipnet:212.227.0.0/16, country:DE]; RCVD_TLS_ALL(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[212.227.15.19:from] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2020 06:18:36 -0000 --Sig_/OrJnGUcm8Wr1o6kmQJCtzC4 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 31 May 2020 11:43:18 +0200 "Hartmann, O." wrote: > On Fri, 29 May 2020 19:22:40 +0000 (UTC) > John Baldwin wrote: >=20 > > Author: jhb > > Date: Fri May 29 19:22:40 2020 > > New Revision: 361633 > > URL: https://svnweb.freebsd.org/changeset/base/361633 > >=20 > > Log: > > Consistently include opt_ipsec.h for consumers of > > .=20 > > This fixes ipsec.ko to include all of IPSEC_DEBUG. > > =20 > > Reviewed by: imp > > MFC after: 2 weeks > > Sponsored by: Netflix > > Differential Revision: https://reviews.freebsd.org/D25046 > >=20 > > Modified: > > head/sys/net/if_enc.c > > head/sys/net/if_ipsec.c > > head/sys/netipsec/ipsec.h > > head/sys/netipsec/ipsec_mbuf.c > > head/sys/netipsec/xform_ah.c > > head/sys/netipsec/xform_esp.c > > head/sys/netipsec/xform_ipcomp.c > >=20 > > Modified: head/sys/net/if_enc.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/net/if_enc.c Fri May 29 19:21:35 2020 > > (r361632) +++ head/sys/net/if_enc.c Fri May 29 19:22:40 > > 2020 (r361633) @@ -32,6 +32,7 @@ > > =20 > > #include "opt_inet.h" > > #include "opt_inet6.h" > > +#include "opt_ipsec.h" > > =20 > > #include > > #include > >=20 > > Modified: head/sys/net/if_ipsec.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/net/if_ipsec.c Fri May 29 19:21:35 2020 > > (r361632) +++ head/sys/net/if_ipsec.c Fri May 29 19:22:40 > > 2020 (r361633) @@ -30,6 +30,7 @@ __FBSDID("$FreeBSD$"); > > =20 > > #include "opt_inet.h" > > #include "opt_inet6.h" > > +#include "opt_ipsec.h" > > =20 > > #include > > #include > >=20 > > Modified: head/sys/netipsec/ipsec.h > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/netipsec/ipsec.h Fri May 29 19:21:35 2020 > > (r361632) +++ head/sys/netipsec/ipsec.h Fri May 29 19:22:40 > > 2020 (r361633) @@ -39,11 +39,6 @@ > > #ifndef _NETIPSEC_IPSEC_H_ > > #define _NETIPSEC_IPSEC_H_ > > =20 > > -#if defined(_KERNEL) && !defined(_LKM) && !defined(KLD_MODULE) > > -#include "opt_inet.h" > > -#include "opt_ipsec.h" > > -#endif > > - > > #include > > #include > > =20 > >=20 > > Modified: head/sys/netipsec/ipsec_mbuf.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/netipsec/ipsec_mbuf.c Fri May 29 19:21:35 > > 2020 (r361632) +++ head/sys/netipsec/ipsec_mbuf.c Fri > > May 29 19:22:40 2020 (r361633) @@ -32,6 +32,8 @@ > > * IPsec-specific mbuf routines. > > */ > > =20 > > +#include "opt_ipsec.h" > > + > > #include > > #include > > #include > >=20 > > Modified: head/sys/netipsec/xform_ah.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/netipsec/xform_ah.c Fri May 29 19:21:35 > > 2020 (r361632) +++ head/sys/netipsec/xform_ah.c Fri > > May 29 19:22:40 2020 (r361633) @@ -38,6 +38,7 @@ > > */ > > #include "opt_inet.h" > > #include "opt_inet6.h" > > +#include "opt_ipsec.h" > > =20 > > #include > > #include > >=20 > > Modified: head/sys/netipsec/xform_esp.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/netipsec/xform_esp.c Fri May 29 19:21:35 > > 2020 (r361632) +++ head/sys/netipsec/xform_esp.c Fri > > May 29 19:22:40 2020 (r361633) @@ -37,6 +37,7 @@ > > */ > > #include "opt_inet.h" > > #include "opt_inet6.h" > > +#include "opt_ipsec.h" > > =20 > > #include > > #include > >=20 > > Modified: head/sys/netipsec/xform_ipcomp.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/netipsec/xform_ipcomp.c Fri May 29 19:21:35 > > 2020 (r361632) +++ head/sys/netipsec/xform_ipcomp.c > > Fri May 29 19:22:40 2020 (r361633) @@ -33,6 +33,7 @@ > > /* IP payload compression protocol (IPComp), see RFC 2393 */ > > #include "opt_inet.h" > > #include "opt_inet6.h" > > +#include "opt_ipsec.h" > > =20 > > #include > > #include > > _______________________________________________ > > svn-src-head@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/svn-src-head > > To unsubscribe, send any mail to > > "svn-src-head-unsubscribe@freebsd.org" =20 >=20 >=20 > In my case, kernel build (make buildkernel) fails with the comnpiler > error shown below while compiling ipsec kernel module. Kernel has > IPSEC support enabled. >=20 > Kind regards, > oh >=20 > [...] > --- all_subdir_ipsec --- > --- ipsec_mod.o --- > /usr/src/sys/netipsec/ipsec_mod.c:114:3: error: implicit declaration > of function 'ipsec_support_enable' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > ipsec_support_enable(ipv4_ipsec_support, &ipv4_methods); ^ > /usr/src/sys/netipsec/ipsec_mod.c:125:3: error: implicit declaration > of function 'ipsec_support_disable' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > ipsec_support_disable(ipv4_ipsec_support); ^ --- all_subdir_ipwfw --- > Building > /usr/obj/usr/src/amd64.amd64/sys/WALHALL/modules/usr/src/sys/modules/ipwf= w/ipw_bss/ipw_bss.ko > --- all_subdir_ipsec --- /usr/src/sys/netipsec/ipsec_mod.c:125:3: > note: did you mean 'ipsec_support_enable'? > /usr/src/sys/netipsec/ipsec_mod.c:114:3: note: 'ipsec_support_enable' > declared here ipsec_support_enable(ipv4_ipsec_support, &ipv4_methods); > ^ 2 errors generated. *** [ipsec_mod.o] Error code 1 >=20 > make[4]: stopped in /usr/src/sys/modules/ipsec FYI: IPSEC is statically built into the kernel via "options IPSEC" --Sig_/OrJnGUcm8Wr1o6kmQJCtzC4 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQSy8IBxAPDkqVBaTJ44N1ZZPba5RwUCXtSdsQAKCRA4N1ZZPba5 R8FqAQDYX0a5cvd5FPLl82ieEIcIe9xnh2WcZn0VLAYTq2imcQEA5vS9EHO9ONzQ g0P3d2BfjbDILjM6QyfZz/cuV/kxOAU= =xPOk -----END PGP SIGNATURE----- --Sig_/OrJnGUcm8Wr1o6kmQJCtzC4--